Negative blood

[mattba10]

Describe the bug Somehow I got negative blood

To Reproduce Steps to reproduce the behavior:

1. Use pipez mod
2. import full blood test tubes and allow all other slots to be empty
3. export empty test tubes

Expected behavior Negative blood should not appear

Screenshots Unfortunately I broke the forge and wont be trying to recreate the bug - but I can IF required load up a test world

Versions

• Forbidden & Arcanus: forbidden_arcanus-1.20.1-2.2.3.jar
• atm9: 0.2.24
• Forge: 47.2.8

Additional context N/A

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 41.22807% with 134 lines in your changes missing coverage. Please review.

Project coverage is 16.56%. Comparing base (d73eafa) to head (2549a1e). Report is 8 commits behind head on master.

:exclamation: Current head 2549a1e differs from pull request most recent head 5ff77f7

Please upload reports for the commit 5ff77f7 to get more accurate results.

Files	Patch %	Lines
server/command.go	9.90%	100 Missing :warning:
server/http.go	76.82%	15 Missing and 4 partials :warning:
server/store.go	57.14%	12 Missing and 3 partials :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   18.04%   16.56%   -1.49%     
==========================================
  Files           9        9              
  Lines        1546     1733     +187     
==========================================
+ Hits          279      287       +8     
- Misses       1216     1407     +191     
+ Partials       51       39      -12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[raghavaggarwal2308]

@ayusht2810 Please resolve conflicts

[raghavaggarwal2308]

@mickmister Gentle reminder for review

[ayusht2810]

@mickmister Gentle reminder to review the PR

[Kshitij-Katiyar]

LGTM 👍 just some non-blocking comments for discussion

For the markdown table in the channel-settings list response, we should probably have it say:

Default: Allow meetings in public channels, private channels, and DMs/GMs

or

Default: Allow meetings only in private channels and DMs/GMs

then simply omit any rows from the table that have the "default" value. We could probably just remove that channel from the saved settings map if the user chooses "default". 0/5 on this though

@mickmister the default setting has a dynamic value (i.e. it can be updated in plugin configuration) Didn't get you on this, please explain.

[mickmister]

@mickmister the default setting has a dynamic value (i.e. it can be updated in plugin configuration) Didn't get you on this, please explain.

@Kshitij-Katiyar Yes I was suggesting we display this value in the response in the wording I posted above. Just so when someone wants to inspect the settings on a channel, they can know what the default value is. Then we can omit any channels that are either unassigned or using the default value

[Kshitij-Katiyar]

Default: Allow meetings only in private channels and DMs/GMs

this was the existing channel setting list

And this is the updated channel setting list

@mickmister I hope this aligns with your suggestions. Please let us know if anything else is required.

[raghavaggarwal2308]

@fmartingr Gentle reminder for review

[raghavaggarwal2308]

@mickmister Fixed the review comments added by you

[ayusht2810]

@AayushChaudhary0001 Fixed the above use case. Can you please re-test the PR?

[raghavaggarwal2308]

@wiggin77 Can you please review this PR. Its already approved but we need a codeowner's approval for merging

[raghavaggarwal2308]

@wiggin77 Fixed the review comments added by you, please re-review

[raghavaggarwal2308]

@wiggin77 Updated. Please re-review