OpenUtau icon indicating copy to clipboard operation
OpenUtau copied to clipboard

Add dark-L vowels to EnXSampaPhonemizer.cs

Open HitCoder9768 opened this issue 1 year ago • 3 comments

for reclists such as my own using phonemes such as O5 for "cold"

HitCoder9768 avatar Jun 23 '24 23:06 HitCoder9768

The GitHub action tests failed. Please ensure that the unit tests passed. You can use dotnet test command to run the tests locally. If your code changes the behaviour of the phonemizer, also change them in the unit tests.

oxygen-dioxide avatar Jun 26 '24 03:06 oxygen-dioxide

(Apologies, I sent this on Discord too but it's kinda important) I also noticed that you've defined the Ol vowel twice; it was already defined, and defining it twice will break the code and the phonemizer will not work (see oxygen's message; I think this is why the tests might be failing). Please fix that, thanks in advance.

lottev1991 avatar Jun 27 '24 07:06 lottev1991

Sorry, it has been a while and there are conflicts. Could you resolve it?

stakira avatar Sep 01 '24 20:09 stakira

This PR is stale because it has been open for 365 days with no activity. It will be closed if no further activity occurs. Thank you.

github-actions[bot] avatar Sep 02 '25 02:09 github-actions[bot]