application icon indicating copy to clipboard operation
application copied to clipboard

feat!: harmonize service account binding

Open aslafy-z opened this issue 1 year ago • 6 comments

Closes #320 Closes #361

  • BREAKING: Rename rbac.serviceAccount.enabled field to rbac.serviceAccount.create.

  • Fix inconsistencies in serviceAccount binding across CronJob, Job, and Deployment templates by introducing a new application.serviceAccountName template:

    rbac.serviceAccount.create rbac.serviceAccount.name result
    true "" (include "application.name" .)
    true "foo" "foo"
    false "" "default"
    false "bar" "bar"
  • Add field automountServiceAccountToken in pod specs controlled by rbac.enabled.

  • Document missing Role and RoleBinding rbac.annotations and rbac.additionalLabels fields.

aslafy-z avatar Nov 15 '24 11:11 aslafy-z

@aslafy-z lets finalize and get this merged

rasheedamir avatar Feb 21 '25 18:02 rasheedamir

@karl-johan-grahn @d3adb5 Can you please give a look? Thank you!

aslafy-z avatar May 28 '25 13:05 aslafy-z

@aslafy-z Can you please resolve the conflicts?

karl-johan-grahn avatar Jul 09 '25 18:07 karl-johan-grahn

@d3adb5 can you plz review it again and approve it?

rasheedamir avatar Jul 09 '25 20:07 rasheedamir

Do make sure to do a major version bump afterwards!

d3adb5 avatar Aug 11 '25 01:08 d3adb5

@rasheedamir @karl-johan-grahn Can you please also review? This PR needs a second approval. @d3adb5 Thank you for taking some time to look at this PR!

aslafy-z avatar Aug 19 '25 09:08 aslafy-z