application icon indicating copy to clipboard operation
application copied to clipboard

Make cronJob work without a service account

Open TomyLobo opened this issue 1 year ago • 4 comments

When using a cronJob without configuring a serviceAccount, I get the following error under "Events" in "kubectl describe":

  Warning  FailedCreate  5m33s (x534 over 2d4h)  job-controller  Error creating: pods "myapp-weekly-dst-28656480-" is forbidden: error looking up service account myapp/myapp: serviceaccount "myapp" not found

This PR fixes that by evaluating rbac.serviceAccount.enabled instead of rbac.enabled, bringing it into alignment with deployment.yaml.

TomyLobo avatar Jun 28 '24 13:06 TomyLobo

There's a check failing that has nothing to do with my changes. Not sure what to do. Help? :)

TomyLobo avatar Jul 04 '24 18:07 TomyLobo

FYI I opened an issue for this: #321. For now let's wait for that to be fixed so we don't merge anything without all the automated tests passing, @TomyLobo.

d3adb5 avatar Jul 06 '24 05:07 d3adb5

@TomyLobo I just rebased the PR (pull with git pull --rebase next time). Tests are running!

aslafy-z avatar Jul 12 '24 14:07 aslafy-z

@rasheedamir validation successful`

github-actions[bot] avatar Jul 12 '24 14:07 github-actions[bot]

Superseeded by https://github.com/stakater/application/pull/363, which will soon be merged.

aslafy-z avatar May 15 '25 08:05 aslafy-z