application
application copied to clipboard
stakater
Adds Jobs feature to the chart.
Hey folks. Thank you very much for maintaining this awesome chart!
This PR introduces the possibility of adding Jobs as part of the deployments.
The use case for this is quite simply to be able to utilize helm hooks for deployments (ie. for database migrations).
Currently, the implementation is very generic and could be used for any kind of purpose alongside the deployment (or CronJob). There is an alternative solution to this that I would also consider (and am happy to provide): Instead of making it very generic (and therefore flexible) we could add a "initJob" config tree to the deployment itself that would come preconfigured. There we would mirror the deployment configuration and behavior (env and such) to make it very simple to execute a helm hook.
Let me know what you think!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Looks good to me. Can you add a commit with commit message #minor and update the CHANGELOG as well? @jeremyzahner
Hello @jeremyzahner @AsfaMumtaz! thank's for greatest helm chart and PR request for Job. Do you plan merge it to master and release new version?
How can I help you with this PR?
I would like to use Job feature in my k8s cluster. Ofc I can cherry-pick this PR to my existing chart, but prefer to use release version)
@jeremyzahner like @AsfaMumtaz requested, can you add a commit with commit message #minor and update the CHANGELOG as well? @SanchosPancho if we don't get a reply, would it be possible for you to update the forked repo?
@karl-johan-grahn @AsfaMumtaz I've just updated the branch. I hope this is what you expected.
@karl-johan-grahn @rasheedamir @AsfaMumtaz any chance to get this merged and released?
@karl-johan-grahn @rasheedamir @AsfaMumtaz any chance to get this merged and released?
Merged.