application icon indicating copy to clipboard operation
application copied to clipboard

Reduce default requests for cpu to 10m and change to QoS

Open rasheedamir opened this issue 1 year ago • 3 comments

https://github.com/stakater/application/blob/master/application/values.yaml#L213-L220

  • reduce to 10m
  • reduce to 50MB

and set same limits

rasheedamir avatar Mar 24 '23 20:03 rasheedamir

@d3adb5 @aslafy-z any thoughts/comments about this one?

rasheedamir avatar Jul 07 '23 07:07 rasheedamir

Usually Helm charts don't set resource constraints by default, so that chart users may size the applications up to fit specific deployments. The preferred QoS class is also highly dependent on each deployment.

Since this project is meant as a generic Helm chart for stateless applications following a specific set of criteria, I'd avoid setting constraints by default to make it as easy as can be for anybody to use the chart.

d3adb5 avatar Jul 07 '23 14:07 d3adb5

Great observation, @d3adb5! Our approach is to make this opinionated while incorporating essential best practices. We're considering establishing absolute minimum requests and limits within the Helm chart. But indeed this is debatable

rasheedamir avatar Aug 10 '23 10:08 rasheedamir