feature reload-on-delete implemented, test cases enhanced
This PR contains the feature "reload-on-delete" as enhancement refering to issue #622.
For beeing backwards compatible an additional flag reload-on-delete at commandline is implemented for using this feature. This corresponding flag reloadOnDelete is also now part in the values.yaml of the helm chart. Testcases are enhaced.
@deschmih Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-2260d728\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-UBI-2260d728
@MuneebAijaz reviewers are welcome ;-) Test cases are enhanced.
@MuneebAijaz - Are you the right person to review this pull request in a timely manner ?
@deschmih you could say so, but a bit busy for last few weeks. I will try to review it today, max tomorrow.
@deschmih you could say so, but a bit busy for last few weeks. I will try to review it today, max tomorrow.
I believe in you brotha
hi @deschmih PR looks fine. can you resolve conflicts and pls separate out docs changes in another PR? There's is an ongoing issue about docs and code workflows running together causing issues.
@deschmih Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-cbf501fc\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-UBI-cbf501fc
@deschmih Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-074a42d8\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-UBI-074a42d8
@MuneebAijaz All conflicts resolved. Removed changes to readme.md (doc). After this PR is approved, a separate PR will be created to modify readme.md.
https://github.com/stakater/Reloader/pull/695/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R395 this doc change is still there.
@MuneebAijaz now it should be fixed
@deschmih Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-cda9fa9b\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-UBI-cda9fa9b
thank you @deschmih. You are the best :heart:
Great job! @deschmih thanks for you input here