Reloader icon indicating copy to clipboard operation
Reloader copied to clipboard

feature reload-on-delete implemented, test cases enhanced

Open deschmih opened this issue 1 year ago • 2 comments

This PR contains the feature "reload-on-delete" as enhancement refering to issue #622. For beeing backwards compatible an additional flag reload-on-delete at commandline is implemented for using this feature. This corresponding flag reloadOnDelete is also now part in the values.yaml of the helm chart. Testcases are enhaced.

deschmih avatar Jun 18 '24 08:06 deschmih

@deschmih Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-2260d728\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-UBI-2260d728

github-actions[bot] avatar Jun 18 '24 08:06 github-actions[bot]

@MuneebAijaz reviewers are welcome ;-) Test cases are enhanced.

deschmih avatar Jun 18 '24 08:06 deschmih

@MuneebAijaz - Are you the right person to review this pull request in a timely manner ?

deschmih avatar Jul 03 '24 08:07 deschmih

@deschmih you could say so, but a bit busy for last few weeks. I will try to review it today, max tomorrow.

MuneebAijaz avatar Jul 03 '24 08:07 MuneebAijaz

@deschmih you could say so, but a bit busy for last few weeks. I will try to review it today, max tomorrow.

I believe in you brotha

bartselect avatar Jul 03 '24 10:07 bartselect

hi @deschmih PR looks fine. can you resolve conflicts and pls separate out docs changes in another PR? There's is an ongoing issue about docs and code workflows running together causing issues.

MuneebAijaz avatar Jul 04 '24 13:07 MuneebAijaz

@deschmih Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-cbf501fc\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-UBI-cbf501fc

github-actions[bot] avatar Jul 08 '24 06:07 github-actions[bot]

@deschmih Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-074a42d8\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-UBI-074a42d8

github-actions[bot] avatar Jul 08 '24 06:07 github-actions[bot]

@MuneebAijaz All conflicts resolved. Removed changes to readme.md (doc). After this PR is approved, a separate PR will be created to modify readme.md.

deschmih avatar Jul 08 '24 06:07 deschmih

https://github.com/stakater/Reloader/pull/695/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R395 this doc change is still there.

MuneebAijaz avatar Jul 08 '24 06:07 MuneebAijaz

@MuneebAijaz now it should be fixed

deschmih avatar Jul 08 '24 06:07 deschmih

@deschmih Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-cda9fa9b\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-UBI-cda9fa9b

github-actions[bot] avatar Jul 08 '24 06:07 github-actions[bot]

thank you @deschmih. You are the best :heart:

MuneebAijaz avatar Jul 08 '24 06:07 MuneebAijaz

Great job! @deschmih thanks for you input here

bartselect avatar Jul 08 '24 08:07 bartselect