Reloader
Reloader copied to clipboard
[BUG] Helm labels and annotations are re-added to K8s manifests built with Kustomize due to update artifacts CI
Describe the bug
#612 has already solved the issue that Helm labels and annotations are added to K8s manifests built with Kustomize (see #587), but as part of the update artifacts
trigger of each new release (e.g. https://github.com/stakater/Reloader/commit/0aa95c968a52ca25196d719239243264708805cc, annotations and labels are being re-added).
To Reproduce
Check the latest update artifacts
for v1.0.69.
Expected behavior
Labels and annotations are not added for deployments files within deployments/kubernetes/manifests
because they don't belong Kustomize configuration, but Helm.
e.g. deployments/kubernetes/manifests/clusterrole.yaml
kind: ClusterRole
metadata:
name: reloader-reloader-role
Screenshots
e.g. deployments/kubernetes/manifests/clusterrole.yaml
kind: ClusterRole
metadata:
annotations:
meta.helm.sh/release-namespace: "default"
meta.helm.sh/release-name: "reloader"
labels:
app: reloader-reloader
chart: "reloader-1.0.69"
release: "reloader"
heritage: "Helm"
app.kubernetes.io/managed-by: "Helm"
name: reloader-reloader-role
Environment
- Helm version: v1.0.69
Additional context
I'm not familiar with the update artifacts
triggers, but somehow, it should only be restricted to add/update those labels/annotations for Helm charts/values, not Kustomize.