Reloader icon indicating copy to clipboard operation
Reloader copied to clipboard

Defeault release label conflicts with Podmonitor

Open githubcdr opened this issue 1 year ago • 1 comments

The release label can be used to specifiy the Prometheus instance.

In https://github.com/stakater/Reloader/blob/master/deployments/kubernetes/chart/reloader/templates/_helpers.tpl#L26 a release label is already added generating this error;

line 11: mapping key "release" already defined at line 8

Can this be changed? Or is there another way to specify the release label for a podmonitor?

githubcdr avatar Mar 26 '23 14:03 githubcdr

These unqualified app, chart, release and heritage labels were added a long time ago, and are likely to conflict with other tenants in addition to prometheus:

{{- define "reloader-labels.chart" -}}
app: {{ template "reloader-fullname" . }}
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
release: {{ .Release.Name | quote }}
heritage: {{ .Release.Service | quote }}
app.kubernetes.io/managed-by: {{ .Release.Service | quote }}
{{- end -}}

joebowbeer avatar Mar 06 '24 06:03 joebowbeer