Reloader icon indicating copy to clipboard operation
Reloader copied to clipboard

Can a UBI image variant be added?

Open IdanAdar opened this issue 2 years ago • 11 comments

For compliance purposes, some cloud providers require images to be based on UBI by RedHat. To that end, we'd like Reloader to offer also an image based on UBI as base image next to distroless

IdanAdar avatar Oct 18 '22 09:10 IdanAdar

@IdanAdar can you please add description and also reasoning?

rasheedamir avatar Oct 18 '22 10:10 rasheedamir

For compliance purposes, some cloud providers require images to be based on UBI by RedHat. To that end, we'd like Reloader to offer also an image based on UBI as base image next to distroless @rasheedamir, and sorry for gettin back late to you. :)

IdanAdar avatar Dec 15 '22 22:12 IdanAdar

Got it @IdanAdar PRs are welcome; we do lots of managed OpenShift as well; so, it will be a great addition

rasheedamir avatar Dec 17 '22 12:12 rasheedamir

@rasheedamir Any guiding tips how this should be done for Reloader specifically?

IdanAdar avatar Jan 06 '23 10:01 IdanAdar

@rasheedamir Any guiding tips how this should be done for Reloader specifically?

IdanAdar avatar Mar 10 '23 19:03 IdanAdar

We're building reloader from source internally with other build image as well as base image. To do that we use the BUILDER_IMAGE and BASE_IMAGE parameters to the Makefile. Perhaps you can use the same?

$ DOCKER_IMAGE=my.image.local/reloader \
   ARCH=amd64 \
   BASE_IMAGE=docker.io/redhat/ubi8-micro:latest \
   make build-image

Have a look at the Makefile.

smuda avatar Mar 13 '23 09:03 smuda

If you don't want to build from source like we do, you can also use the binary from the published image in a new Dockerfile like this:

FROM docker.io/stakater/reloader:v1.0.15 as SRC

FROM docker.io/redhat/ubi8-micro:latest

WORKDIR /
COPY --from=SRC /manager .
USER 65532:65532

# Port for metrics and probes
EXPOSE 9090

ENTRYPOINT ["/manager"]

Build with docker build . -t my-reloader:v1.0.15

smuda avatar Mar 13 '23 10:03 smuda

@IdanAdar did you manage to build the image and/or create a PR to publish UBI-based reloader?

smuda avatar Jul 08 '23 08:07 smuda

I could not, no.

IdanAdar avatar Jul 28 '23 03:07 IdanAdar

What model did you try and what problem did you run into?

smuda avatar Jul 28 '23 06:07 smuda

I also need this, for compliance reasons, so I have opened a PR. Happy to change whatever is needed to get it in.

daniel-butler-irl avatar Oct 18 '23 12:10 daniel-butler-irl