Reloader icon indicating copy to clipboard operation
Reloader copied to clipboard

Published 20 hours ago • verified publisher icon stakater

Remove server side call from podmonitoring template

Open kenske opened this issue 2 years ago • 1 comments

The .Capabilities.APIVersions.Has is server side, which means it breaks in workflows where helm template is used (ArgoCD for example)

kenske avatar Aug 12 '22 16:08 kenske

@kenske Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-329-328442c1

stakater-user avatar Aug 12 '22 16:08 stakater-user

@kenske I didn't understand, can you please explain your use case? We do not want the podMonitor to be enabled if it doesn't exist in the cluster.

faizanahmad055 avatar Sep 27 '22 20:09 faizanahmad055

@faizanahmad055 If you're generating k8s manifests using helm template, the .Capabilities.APIVersions.Has function won't work. There are many use cases for helm template, including applying the changes to an external cluster using GitOps. I thought that having .Values.reloader.podMonitor.enabled would be enough, and it will error out if the monitoring API is not available anyway.

kenske avatar Sep 28 '22 02:09 kenske