IngressMonitorController icon indicating copy to clipboard operation
IngressMonitorController copied to clipboard

Provide a way to override the monitor name with a field monitorName

Open dandonovsc opened this issue 3 years ago • 3 comments

Added an explicit field on the EndpointMonitor resource to allow an optional monitor name override that can use special or upper case characters. The current implementation uses metadata.name + metadata.namespace ( or {{.Name}} - {{.Namespace}}) in an optional template. The limitation here is the validation is Kubernetes restricting the character set to regex pattern:

a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

dandonovsc avatar Feb 08 '22 20:02 dandonovsc

@dandonovsc Image is available for testing. docker pull stakater/IngressMonitorController:SNAPSHOT-PR-376-9a6200d3

stakater-user avatar Feb 08 '22 20:02 stakater-user

$ docker pull stakater/IngressMonitorController:SNAPSHOT-PR-376-9a6200d3 invalid reference format: repository name must be lowercase

dandonovsc avatar Feb 08 '22 21:02 dandonovsc

@dandonovsc issue is fixed in #377 plz try again

usamaahmadkhan avatar Mar 08 '22 13:03 usamaahmadkhan

@dandonovsc Yikes! You better fix it before anyone else finds out! Build has Failed!

stakater-user avatar Feb 10 '23 20:02 stakater-user

@dandonovsc Image is available for testing. docker pull stakater/ingressmonitorcontroller:SNAPSHOT-PR-376-90c3caaf

stakater-user avatar Feb 10 '23 20:02 stakater-user