IngressMonitorController icon indicating copy to clipboard operation
IngressMonitorController copied to clipboard

Warnings related to deprecated ingress api version / Kubernetes 1.22+ support

Open rombert opened this issue 4 years ago • 3 comments

Hi,

I have deployed IMC on a kubernetes cluster that is running on version 1.21 . I plan to move to 1.22 soon. I have noticed these warnings in the logs

W1223 10:03:50.082652       1 warnings.go:70] extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress

This makes the think that the controller will not work with Kubernetes 1.22 or newer. It would be great it it could be updated for these newer Kubernetes versions.

Reference: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/

rombert avatar Dec 23 '21 10:12 rombert

@rombert would you like to make a PR for it?

rasheedamir avatar Dec 24 '21 10:12 rasheedamir

@rasheedamir - sorry, I have no Go knowledge/experience for this kind of PR.

rombert avatar Dec 24 '21 11:12 rombert

FWIW, this is not working at all in 1.22

{"level":"error","ts":1643141833.4718075,"logger":"controller-runtime.manager.controller.endpointmonitor","msg":"Reconciler error","reconciler group":"endpointmonitor.stakater.com","reconciler kind":"EndpointMonitor","name":"travelsfactory-ro","namespace":"cust-travelsfactory-ro","error":"no matches for kind \"Ingress\" in version \"extensions/v1beta1\"","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:132\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:302\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1.2\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:216\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1\n\t/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext\n\t/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.UntilWithContext\n\t/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:99"}

It would be great is someone could contribute a fix, I'd be happy to test it out.

rombert avatar Jan 25 '22 20:01 rombert

hi @rombert , this issue has been resolved by the above mentioned PR, feel free to reopen this if you find any issues.

MuneebAijaz avatar Oct 28 '22 10:10 MuneebAijaz