IngressMonitorController icon indicating copy to clipboard operation
IngressMonitorController copied to clipboard

Feature/advanced error handling

Open artemlive opened this issue 4 years ago • 24 comments

Here is the issue with the detailed description of this improvement: #293

artemlive avatar Nov 02 '20 21:11 artemlive

@artemlive Yikes! You better fix it before anyone else finds out! Build 1 has Failed!

stakater-user avatar Nov 02 '20 21:11 stakater-user

@artemlive Yikes! You better fix it before anyone else finds out! Build 2 has Failed!

stakater-user avatar Nov 02 '20 21:11 stakater-user

@artemlive Yikes! You better fix it before anyone else finds out! Build 3 has Failed!

stakater-user avatar Nov 02 '20 21:11 stakater-user

@artemlive Yikes! You better fix it before anyone else finds out! Build 4 has Failed!

stakater-user avatar Nov 02 '20 22:11 stakater-user

@artemlive Yikes! You better fix it before anyone else finds out! Build 5 has Failed!

stakater-user avatar Nov 03 '20 16:11 stakater-user

@artemlive Yikes! You better fix it before anyone else finds out! Build 6 has Failed!

stakater-user avatar Nov 03 '20 16:11 stakater-user

@artemlive Yikes! You better fix it before anyone else finds out! Build 7 has Failed!

stakater-user avatar Nov 03 '20 17:11 stakater-user

Strange thing, because all tests have been passed locally.

time make test &> /dev/null; echo $?

real 0m42.501s user 0m35.419s sys 0m8.937s 0

artemlive avatar Nov 03 '20 17:11 artemlive

@artemlive Yikes! You better fix it before anyone else finds out! Build 8 has Failed!

stakater-user avatar Nov 03 '20 17:11 stakater-user

@artemlive Yikes! You better fix it before anyone else finds out! Build 9 has Failed!

stakater-user avatar Nov 03 '20 17:11 stakater-user

Linter, tests, and builds are fine I see the mistake in Makefile in the verify section. At least in my local env, it doesn't work because the project doesn't have "test" directory. All other stuff is the same and it works locally. Could someone tell me what exact problem with the last build and why Jenkins build has been failed. Thank you!

artemlive avatar Nov 03 '20 18:11 artemlive

@artemlive Yikes! You better fix it before anyone else finds out! Build 10 has Failed!

stakater-user avatar Nov 12 '20 06:11 stakater-user

Hi @artemlive, everything was fine but the test cases were failing against a different provider. I am looking into it and hopefully will resolve that today. In future, we will move to github actions so that anyone can view the pipeline and there is no inconvenience of such sorts. I'll try to get this prioritized !

ahmedwaleedmalik avatar Nov 12 '20 07:11 ahmedwaleedmalik

@artemlive Image is available for testing. docker pull stakater/ingressmonitorcontroller:SNAPSHOT-PR-294-12

stakater-user avatar Nov 12 '20 12:11 stakater-user

@artemlive can you plz resolve the conflicts and lets get this merged?

rasheedamir avatar Mar 14 '21 08:03 rasheedamir

@artemlive any plans to update this PR?

rasheedamir avatar May 11 '21 06:05 rasheedamir

@rasheedamir Hello, yes, I'll try to fix all of them this week.

artemlive avatar Jun 14 '21 13:06 artemlive

Any update on this?? Would be great to have

tomjohnburton avatar Aug 23 '21 15:08 tomjohnburton

I'm glad I found this PR, I was about to start working on something similar. Any chance this will make progress soon?

mmiller1 avatar Jan 21 '22 18:01 mmiller1

Is there any ETA for merging this PR and releasing a new version?

Thanks!

bilby91 avatar Mar 25 '22 21:03 bilby91

Hello, we also would like this PR to be merged, thanks for your help !

julien-michaud avatar Mar 21 '23 17:03 julien-michaud

Hello, folks! I'm sorry for being gone so long. I'll review all the code and fix the conflicts as soon as possible.

artemlive avatar Mar 28 '23 14:03 artemlive

@artemlive have you had time to look at this again?

karl-johan-grahn avatar Jul 26 '23 08:07 karl-johan-grahn

@artemlive Any chance you'll get time to actually look at this soon?

davidgibbons avatar Oct 18 '23 17:10 davidgibbons

@artemlive I would also be very curious if there is any update to this matter? :)

andreas-mueller-bb avatar Feb 26 '24 08:02 andreas-mueller-bb