IngressMonitorController icon indicating copy to clipboard operation
IngressMonitorController copied to clipboard

Uptime returns a json unmarshal error

Open travisghansen opened this issue 4 years ago • 5 comments

I'm attempting to use the uptime configuration and it works fine to create entries, but deleting them and generally looking up the entries is failing:

time="2020-03-17T17:57:06Z" level=info msg="Could not Unmarshal Json Response"

I've confirmed my apiKey has access to the relevant endpoint.

After digging through the code briefly it also appears paging of any sort is missing to work when lots of monitors are defined.

Some potential options to add to the GetAll endpoint as well:

  • ?monitoring_service_type=HTTP
  • ?search= (not sure if it's possible to search via the Ingress hostname)

It would be great to be able to specify a set of tags to apply globally (ie: in the config, not necessarily via annotation on a per-ingress basis).

travisghansen avatar Mar 17 '20 19:03 travisghansen

@travisghansen would you like to make a PR for the issue with listing and deleting?

Great suggestion for pagination support & also for global tags; please create separate issues for them

rasheedamir avatar Mar 17 '20 20:03 rasheedamir

I'm pretty abysmal at go or I'd be more help :(

travisghansen avatar Mar 17 '20 20:03 travisghansen

This issue is stale because it has been open for 60 days with no activity.

github-actions[bot] avatar Apr 14 '23 01:04 github-actions[bot]

This issue was closed because it has been inactive for 30 days since being marked as stale.

github-actions[bot] avatar May 18 '23 01:05 github-actions[bot]

Reopening issues that inadvertently were closed as stale

karl-johan-grahn avatar Sep 26 '23 18:09 karl-johan-grahn