IngressMonitorController icon indicating copy to clipboard operation
IngressMonitorController copied to clipboard

Published 20 hours ago • verified publisher icon stakater

Add support for basic auth (uptimerobot.com)

Open xanonid opened this issue 5 years ago • 16 comments

uptimerobot.com supports adding basic auth (http_username & http_password) to monitors. It would be nice, if IngressMonitorController could set those settings via related Ingress annotations/secrets.

xanonid avatar Mar 15 '19 18:03 xanonid

This also applies to Pingdom!

jess-belliveau avatar Mar 21 '19 02:03 jess-belliveau

I've submitted a PR to bring this to Pingdom via an annotation and OS env (mounted secret); https://github.com/stakater/IngressMonitorController/pull/154

jess-belliveau avatar Apr 09 '19 10:04 jess-belliveau

I've submitted a PR implementation for Statuscake #170

DhiaTN avatar Apr 29 '19 00:04 DhiaTN

@xanonid @SinFulNard @DhiaTN why not having an annotation pointing to a secret for the credentials? this way you dont need to mount the secret into the deployment/pod for the get.env

grebois avatar May 05 '19 20:05 grebois

@grebois - I didn't have the thought at the time (or experience to achieve that). So went with what I could think of.

I agree, its likely a better method of exposing the secret.

jess-belliveau avatar May 07 '19 00:05 jess-belliveau

@SinFulNard are you at kubecon this next week? if you are lets talk about it f2f

grebois avatar May 17 '19 12:05 grebois

Hi @grebois, me and @waseem-h will be there at KubeCon. We'd be happy to meet if you want to discuss something or just say Hi!

hazim1093 avatar May 17 '19 14:05 hazim1093

Definitely, let's catch up, are you already in Barcelona? whazatpp me +49 152 0249 6483

grebois avatar May 17 '19 19:05 grebois

@hazim1093 @waseem-h @SinFulNard please leave this open for a bit longer I will work on a PR together with @DhiaTN to refactor this functionality, including https://github.com/stakater/IngressMonitorController/issues/182 and https://github.com/stakater/IngressMonitorController/issues/183

grebois avatar May 20 '19 16:05 grebois

Definitely, let's catch up, are you already in Barcelona? whazatpp me +49 152 0249 6483

Hi, Sorry I didn't get notification for the comment, just saw :(

hazim1093 avatar May 28 '19 08:05 hazim1093

@grebois will you continue on this one?

rasheedamir avatar Sep 07 '19 18:09 rasheedamir

@rasheedamir not for the moment, but I would like to keep it open.

grebois avatar Sep 08 '19 02:09 grebois

ok sure! @grebois

rasheedamir avatar Sep 08 '19 18:09 rasheedamir

This issue is stale because it has been open for 60 days with no activity.

github-actions[bot] avatar May 24 '23 01:05 github-actions[bot]

This issue was closed because it has been inactive for 30 days since being marked as stale.

github-actions[bot] avatar Jun 23 '23 02:06 github-actions[bot]

Reopening issues that inadvertently were closed as stale

karl-johan-grahn avatar Sep 26 '23 18:09 karl-johan-grahn