staircase icon indicating copy to clipboard operation
staircase copied to clipboard

Add type hinting

Open venaturum opened this issue 5 years ago • 2 comments

There are currently no type-hints in staircase.

Background/resources: https://docs.python.org/3/library/typing.html https://mypy.readthedocs.io/en/stable/cheat_sheet_py3.html https://realpython.com/lessons/type-hinting/

https://github.com/staircase-dev/staircase/blob/master/staircase/_typing.py has been created for custom types (see https://github.com/pandas-dev/pandas/blob/master/pandas/_typing.py for inspiration)

Please add new issue for each individual file with typing added, and commit separately.

venaturum avatar Oct 14 '20 05:10 venaturum

Hi! I wouldn't definitely close this issue, as there are some type hints I wasn't able to figure out, or maybe let this close but we could do a new issue for mypy compliance. Whatever you think is best :)

PabloRuizCuevas avatar Oct 24 '22 12:10 PabloRuizCuevas

@PabloRuizCuevas no worries

venaturum avatar Oct 25 '22 09:10 venaturum