Maximilian Stadler

Results 18 comments of Maximilian Stadler

Thanks for addressing the feedback, looks good to me.

I would say that the problem still exists in general. In our implementations, we should have enough workarounds in place to avoid these issues. If we want to simplify the...

>Thanks for the fixes, it works now! Interestingly, in most of the logging code I had to remove the .date() except for data_structures_fifo.py::pop()::sell_date StockSplitEvent::date In these cases if I remove...

>DEGIRO import runs now (with the manual handling of the known unsupported buy/sell stock at the same day variation). wait, you actually have buy and immediately sell use-cases? :D what...

Great news, would you mind going over the conversations to see if there is still a comment not addressed? I'll do the same :)

yfinance issues seems like a show-stopper for unfortunately

@szotsaki likely not nicely or over-engineered, but i revisited the historical prices through YF again - now with a manual and human-readable cache (i.e. in case YF breaks in the...

I trust you with the correctness of the DeGiro and IBKR converts, can't say much about correctness besides most of the things making sense.