hook.io icon indicating copy to clipboard operation
hook.io copied to clipboard

JSHINT bankruptcy / Add .jshint file and clean-up codebase

Open Marak opened this issue 8 years ago • 2 comments

The entire codebase needs a JSHINT review and cleaning.

This could be a good opportunity for someone new to the project to help contribute.

First pull request would be adding the jshint configuration and documentation, then performing a lint on one small file. Once we have this in place, we can begin linting every file.

Do not want a waterfalled lint of the entire system. Due to the cross-cutting nature of changes I'd like to review changes to every file as an individual commit.

Marak avatar Mar 06 '16 21:03 Marak

Is JSHINT a strict requirement for hook.io? If not, I’d like to vote for eslint.

sbruchmann avatar Mar 06 '16 23:03 sbruchmann

@sbruchmann -

I'd prefer to stick with what I know works, but it's really up to whoever is willing to update the codebase. I don't know if we need any of the advanced features eslint provides over jshint?

If you can provide a PR will eslint configuration and default settings I will review it for possible usage.

Marak avatar Mar 06 '16 23:03 Marak