zone-file-py icon indicating copy to clipboard operation
zone-file-py copied to clipboard

Published 20 hours ago • verified publisher icon stacks-network

Python3 compatibility

Open DonnchaC opened this issue 8 years ago • 5 comments

Thanks for creating this library. This PR fixes some issues I noticed when trying to use the library under Python 3. With these changes the unittests now all pass under Python 2 and Python 3. I have not tested the rest of the codebase, there may still be issues in areas without unit test coverage.

You should consider using tox to run your unit tests automatically in Python 2 and Python 3 environments.

As an aside will you be keeping this library up to date on PyPi? It's a little confusing that the package name in this repo doesn't match the published package.

DonnchaC avatar Aug 21 '16 14:08 DonnchaC

Wow, this is awesome! Thank you for taking the time to send us a PR! I'll run it through our integration tests today :)

jcnelson avatar Aug 23 '16 15:08 jcnelson

Great work and thank you @DonnchaC, appreciate the PR.

shea256 avatar Aug 23 '16 18:08 shea256

All tests are now run automatically by Tox in Python 2.7, Python 3.4 and Python 3.5 environments. Sorry about the noisy commits as I was trying to get CircleCI to support other Python versions.

DonnchaC avatar Aug 31 '16 10:08 DonnchaC

Any word on this branch getting merged?

nadermx avatar Sep 03 '18 04:09 nadermx

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 08 '20 06:03 CLAassistant