subdomain-registrar icon indicating copy to clipboard operation
subdomain-registrar copied to clipboard

feat: setup typescript compilation and migrate lookup file

Open pradel opened this issue 2 years ago • 2 comments

Description

This change is the first one in the codebase migration from Flow to typescript. Right now babel is in charge of compiling both flow and typescript files but in the long term, we will remove babel and just use the typescript compiler to match the other stacks projects config. In this pull request I just added the necessary config to allow babel to compile both Flow and Ts files. I also converted the lookup.js file to typescript, mostly changed the types and added 2 ts-ignore to silence 2 errors and not change the current code.

If you like the way this pr is doing things, we can start migrating more files to typescript.

This change is part of the M1 https://github.com/stacksgov/Stacks-Grants/issues/282.

This pull request is a cleanup of https://github.com/stacks-network/subdomain-registrar/pull/82 made by @Akirtovskis to fix the CI issues he faced.

Checklist

  • [x] Code is commented where needed
  • [x] Unit test coverage for new or modified code paths
  • [x] npm run test passes
  • [ ] Changelog is updated
  • [x] Tag 1 of @CharlieC3 or @wileyj

pradel avatar Apr 11 '22 17:04 pradel