subdomain-registrar icon indicating copy to clipboard operation
subdomain-registrar copied to clipboard

feat: migrate-lookups-file-flow-to-ts

Open Akirtovskis opened this issue 3 years ago • 2 comments

Description

Migrated lookups.ts file from Flow to TypeScript as part of a bigger task to migrate the whole project types from Flow to TS.

  1. Following this PR the next task was to start migrating from Flow to Ts: https://github.com/stacks-network/subdomain-registrar/pull/80

  2. This change is part of M1 of this grant: https://github.com/stacksgov/Stacks-Grants/issues/282

  3. After the whole repo is migrated to the TS it should improve dev experience and productivity as TypeScript is used across all the other Stacks repos.

Does this introduce a breaking change?

This does not include a breaking change.

Are documentation updates required?

Yes, once this will get a green light, I will add documentation for TS setup either on this branch or the one right after this one.

Testing information

  1. Review the config
  2. Review lookups.ts
  3. Run npm run tsc and see no errors

Akirtovskis avatar Mar 15 '22 09:03 Akirtovskis

Codecov Report

Merging #82 (e61d6be) into master (da2d144) will not change coverage. The diff coverage is n/a.

:exclamation: Current head e61d6be differs from pull request most recent head 784dc8a. Consider uploading reports for the commit 784dc8a to get more accurate results

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   58.19%   58.19%           
=======================================
  Files           8        8           
  Lines         665      665           
=======================================
  Hits          387      387           
  Misses        278      278           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da2d144...784dc8a. Read the comment docs.

codecov[bot] avatar Mar 15 '22 10:03 codecov[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 16 '23 06:11 CLAassistant