subdomain-registrar
subdomain-registrar copied to clipboard
chore: replace resolveZoneFileToProfile from blockstack SDK
Description
While browsing the repo I found this function that can be extracted from the blockstack package. I will submit other pull requests if I find other parts that can be migrated easily.
Type of Change
Code change.
Does this introduce a breaking change?
No
Checklist
- [ ] Code is commented where needed
- [ ] Unit test coverage for new or modified code paths
- [ ]
npm run testpasses - [ ] Changelog is updated
- [ ] Tag 1 of @wileyj or @CharlieC3
Closing then re-opening PR to try and re-trigger CI.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 58.19%. Comparing base (
d2897c3) to head (1ea8e1b). Report is 49 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #72 +/- ##
=======================================
Coverage 58.19% 58.19%
=======================================
Files 8 8
Lines 665 665
=======================================
Hits 387 387
Misses 278 278
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I see that CI / build-publish (pull_request) is failing but it doesn't seems related to that pr
@pradel I'll submit a fix for that in a separate PR.
Closing then re-opening PR to try and re-trigger CI.