subdomain-registrar icon indicating copy to clipboard operation
subdomain-registrar copied to clipboard

chore: replace resolveZoneFileToProfile from blockstack SDK

Open pradel opened this issue 3 years ago • 6 comments

Description

While browsing the repo I found this function that can be extracted from the blockstack package. I will submit other pull requests if I find other parts that can be migrated easily.

Type of Change

Code change.

Does this introduce a breaking change?

No

Checklist

  • [ ] Code is commented where needed
  • [ ] Unit test coverage for new or modified code paths
  • [ ] npm run test passes
  • [ ] Changelog is updated
  • [ ] Tag 1 of @wileyj or @CharlieC3

pradel avatar Feb 01 '22 15:02 pradel

Closing then re-opening PR to try and re-trigger CI.

CharlieC3 avatar Feb 01 '22 17:02 CharlieC3

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.19%. Comparing base (d2897c3) to head (1ea8e1b). Report is 49 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   58.19%   58.19%           
=======================================
  Files           8        8           
  Lines         665      665           
=======================================
  Hits          387      387           
  Misses        278      278           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 01 '22 17:02 codecov[bot]

I see that CI / build-publish (pull_request) is failing but it doesn't seems related to that pr

pradel avatar Feb 01 '22 18:02 pradel

@pradel I'll submit a fix for that in a separate PR.

CharlieC3 avatar Feb 01 '22 18:02 CharlieC3

Closing then re-opening PR to try and re-trigger CI.

CharlieC3 avatar Feb 02 '22 15:02 CharlieC3

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 16 '23 06:11 CLAassistant