subdomain-registrar icon indicating copy to clipboard operation
subdomain-registrar copied to clipboard

Support for using and adminpassword via Env Var

Open wileyj opened this issue 3 years ago • 1 comments

Rather than using a hardcoded adminPassword in the config file like :

  adminPassword: 'NEEDS-A-PASSWORD',

It would be better to use an env if present: ADMIN_PASSWORD="my-fake-password".

This would prevent adding an admin password in plain-text, similar to how the payment & owner keys are handled.

https://github.com/blockstack/subdomain-registrar/blob/master/src/config.js#L53

wileyj avatar Mar 23 '21 14:03 wileyj