stacks-core icon indicating copy to clipboard operation
stacks-core copied to clipboard

Feat: remove old parser

Open brice-stacks opened this issue 2 weeks ago • 2 comments

This removes the v1 parser. We'll need to verify that block validation or genesis sync still works with this change in place.

brice-stacks avatar Dec 10 '25 18:12 brice-stacks

Codecov Report

:x: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 72.61%. Comparing base (8826d5c) to head (88c593d). :warning: Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
clarity/src/vm/ast/mod.rs 88.88% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6754      +/-   ##
===========================================
- Coverage    76.58%   72.61%   -3.97%     
===========================================
  Files          580      579       -1     
  Lines       361096   360363     -733     
===========================================
- Hits        276555   261695   -14860     
- Misses       84541    98668   +14127     
Files with missing lines Coverage Δ
...ity/src/vm/analysis/type_checker/v2_1/tests/mod.rs 90.34% <ø> (-9.42%) :arrow_down:
clarity/src/vm/ast/definition_sorter/tests.rs 100.00% <100.00%> (ø)
clarity/src/vm/tests/contracts.rs 100.00% <100.00%> (ø)
stackslib/src/chainstate/stacks/db/transactions.rs 87.94% <100.00%> (-9.01%) :arrow_down:
stackslib/src/chainstate/tests/mod.rs 76.09% <ø> (-1.85%) :arrow_down:
stackslib/src/net/api/callreadonly.rs 91.21% <100.00%> (ø)
stackslib/src/net/api/fastcallreadonly.rs 91.28% <100.00%> (ø)
stackslib/src/net/api/getconstantval.rs 41.93% <100.00%> (-50.00%) :arrow_down:
stackslib/src/net/api/getdatavar.rs 88.97% <100.00%> (ø)
stackslib/src/net/api/getistraitimplemented.rs 92.07% <100.00%> (+0.19%) :arrow_up:
... and 4 more

... and 282 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8826d5c...88c593d. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 10 '25 19:12 codecov[bot]

Definitely got a lot of failing unit tests. I assume related to trying ot call non existent parser v1 code and defaultint to the new so error types are prob diff.

jacinta-stacks avatar Dec 10 '25 20:12 jacinta-stacks