Use global signer state machine to evaluate proposals
Closes https://github.com/stacks-network/stacks-core/issues/6092
Pulled out the changes for https://github.com/stacks-network/stacks-core/issues/6176
Note that regr_use_block_header_pk will not pass until https://github.com/stacks-network/stacks-core/pull/6181 is merged.
Codecov Report
Attention: Patch coverage is 70.91470% with 566 lines in your changes missing coverage. Please review.
Project coverage is 77.30%. Comparing base (
0695b41) to head (344a652). Report is 64 commits behind head on develop.
:x: Your project status has failed because the head coverage (77.30%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files
@@ Coverage Diff @@
## develop #6180 +/- ##
============================================
+ Coverage 61.96% 77.30% +15.34%
============================================
Files 540 540
Lines 392326 392840 +514
Branches 323 323
============================================
+ Hits 243090 303671 +60581
+ Misses 149228 89161 -60067
Partials 8 8
| Files with missing lines | Coverage Δ | |
|---|---|---|
| stacks-signer/src/client/mod.rs | 99.28% <100.00%> (+54.87%) |
:arrow_up: |
| stacks-signer/src/config.rs | 93.69% <100.00%> (+18.26%) |
:arrow_up: |
| stacks-signer/src/lib.rs | 90.00% <ø> (ø) |
|
| stacks-signer/src/tests/chainstate.rs | 100.00% <100.00%> (+18.61%) |
:arrow_up: |
| testnet/stacks-node/src/nakamoto_node/miner.rs | 85.00% <100.00%> (+0.19%) |
:arrow_up: |
| stacks-signer/src/runloop.rs | 85.25% <50.00%> (+0.14%) |
:arrow_up: |
| libsigner/src/v0/signer_state.rs | 90.86% <96.55%> (+4.71%) |
:arrow_up: |
| stacks-signer/src/signerdb.rs | 84.90% <96.36%> (+19.90%) |
:arrow_up: |
| stacks-signer/src/v0/signer.rs | 87.35% <91.78%> (+3.77%) |
:arrow_up: |
| ...tacks-node/src/tests/signer/commands/block_wait.rs | 21.42% <0.00%> (-0.18%) |
:arrow_down: |
| ... and 7 more |
... and 309 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 0695b41...344a652. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
When working on the tenure-extend-during-replay PR, I realized that this PR "breaks" the logic for broadcasting a
LocalStateMachineupdate, since the replay set is not considered. I've made a small tweak that fixes this: hstove@4b3c6f2
I think you hadn't pulled since I fixed this already in 283fbf6af62a05f6f223a3ec3a3304af331fec3c
Replaced by https://github.com/stacks-network/stacks-core/pull/6215
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.