stacks-core icon indicating copy to clipboard operation
stacks-core copied to clipboard

Feat/signer two phase commit

Open jferrant opened this issue 8 months ago • 1 comments

jferrant avatar May 05 '25 21:05 jferrant

Codecov Report

Attention: Patch coverage is 66.85714% with 116 lines in your changes missing coverage. Please review.

Project coverage is 77.76%. Comparing base (32461ef) to head (d37a3f6). Report is 127 commits behind head on develop.

Files with missing lines Patch % Lines
stacks-node/src/tests/signer/v0.rs 24.57% 89 Missing :warning:
stacks-signer/src/v0/signer.rs 84.61% 18 Missing :warning:
libsigner/src/v0/messages.rs 40.00% 9 Missing :warning:

:x: Your project status has failed because the head coverage (77.76%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6082      +/-   ##
===========================================
+ Coverage    76.77%   77.76%   +0.99%     
===========================================
  Files          545      545              
  Lines       347417   347709     +292     
  Branches       323      323              
===========================================
+ Hits        266719   270405    +3686     
+ Misses       80690    77296    -3394     
  Partials         8        8              
Files with missing lines Coverage Δ
...tacks-node/src/nakamoto_node/stackerdb_listener.rs 84.25% <100.00%> (+0.04%) :arrow_up:
stacks-signer/src/chainstate/mod.rs 90.56% <ø> (-1.14%) :arrow_down:
stacks-signer/src/monitoring/mod.rs 86.45% <100.00%> (+0.43%) :arrow_up:
stacks-signer/src/monitoring/prometheus.rs 100.00% <ø> (ø)
stacks-signer/src/signerdb.rs 84.50% <100.00%> (-2.30%) :arrow_down:
stacks-signer/src/v0/tests.rs 89.00% <100.00%> (-0.42%) :arrow_down:
libsigner/src/v0/messages.rs 83.19% <40.00%> (+5.43%) :arrow_up:
stacks-signer/src/v0/signer.rs 79.76% <84.61%> (-1.91%) :arrow_down:
stacks-node/src/tests/signer/v0.rs 36.60% <24.57%> (+3.01%) :arrow_up:

... and 299 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32461ef...d37a3f6. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 09 '25 20:05 codecov[bot]

Replaced by https://github.com/stacks-network/stacks-core/pull/6319

jferrant avatar Jul 21 '25 21:07 jferrant

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Jul 29 '25 00:07 github-actions[bot]