stacks-core icon indicating copy to clipboard operation
stacks-core copied to clipboard

[Mutations Testing] for PR: MARF'ed Nakamoto chainstate #4930

Open ASuciuX opened this issue 1 year ago • 4 comments

Is your feature request related to a problem? Please describe. Mutations Testing works by modifying the body of the function to a default return. eg. if i have a sum function which returns int -> the mutant would replace it with return 0

This issue is done in order to track which functions got their tests fixed after being highlighted by the mutants.

Resources

ASuciuX avatar Jul 11 '24 13:07 ASuciuX

Timeout Mutants - docs

  • [x] stackslib/src/chainstate/nakamoto/mod.rs:745:9: replace NakamotoBlockHeader::verify_signer_signatures -> Result<u32, ChainstateError> with Ok(1) in 209.3s build + 3552.0s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:745:9: replace NakamotoBlockHeader::verify_signer_signatures -> Result<u32, ChainstateError> with Ok(0) in 203.3s build + 3525.1s test
  • [x] stackslib/src/net/p2p.rs:4782:9: replace PeerNetwork::refresh_reward_cycles -> Result<(), net_error> with Ok(()) in 203.7s build + 3526.5s test

ASuciuX avatar Jul 11 '24 14:07 ASuciuX

Missed Mutants - docs

  • [ ] stackslib/src/net/relay.rs:524:9: replace Relayer::validate_blocks_push -> Result<(), net_error> with Ok(()) in 205.8s build + 1906.7s test
  • [ ] stackslib/src/util_lib/db.rs:915:9: replace IndexDBTx<'a, C, T>::get_indexed_ref -> Result<Option<String>, Error> with Ok(None) in 179.3s build + 2351.1s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:173:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_stacks_block_time_for_block -> Option with Some(1) in 179.6s build + 2308.8s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:232:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_burnchain_tokens_spent_for_block -> Option with None in 185.0s build + 2338.2s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:262:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_tokens_earned_for_block -> Option with Some(1) in 168.0s build + 2362.3s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:402:9: replace <impl HeadersDB for ChainstateTx<'a>>::get_burnchain_tokens_spent_for_winning_block -> Option with None in 187.1s build + 2336.2s test
  • [ ] stackslib/src/util_lib/db.rs:915:9: replace IndexDBTx<'a, C, T>::get_indexed_ref -> Result<Option<String>, Error> with Ok(Some(String::new())) in 187.4s build + 2381.6s test
  • [ ] stackslib/src/net/relay.rs:569:9: replace Relayer::validate_nakamoto_blocks_push -> Result<(), net_error> with Ok(()) in 215.7s build + 2387.2s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:143:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_consensus_hash_for_block -> Option<ConsensusHash> with None in 188.4s build + 2343.1s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:232:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_burnchain_tokens_spent_for_block -> Option with Some(0) in 191.6s build + 2381.8s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:351:9: replace <impl HeadersDB for ChainstateTx<'a>>::get_vrf_seed_for_block -> Option<VRFSeed> with None in 192.7s build + 2409.0s test
  • [ ] stackslib/src/util_lib/db.rs:915:9: replace IndexDBTx<'a, C, T>::get_indexed_ref -> Result<Option<String>, Error> with Ok(Some("xyzzy".into())) in 178.4s build + 2352.1s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:101:9: replace <impl GetTenureStartId for MARF<StacksBlockId>>::get_tenure_block_id -> Result<Option<TenureBlockId>, DBError> with Ok(None) in 154.3s build + 2352.4s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:232:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_burnchain_tokens_spent_for_block -> Option with Some(1) in 184.4s build + 2354.4s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:402:9: replace <impl HeadersDB for ChainstateTx<'a>>::get_burnchain_tokens_spent_for_winning_block -> Option with Some(1) in 180.0s build + 2375.2s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:247:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_burnchain_tokens_spent_for_winning_block -> Option with None in 183.2s build + 2357.4s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:374:9: replace <impl HeadersDB for ChainstateTx<'a>>::get_miner_address -> Option<StacksAddress> with None in 184.5s build + 2369.8s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:59:9: replace <impl GetTenureStartId for StacksDBConn<'_>>::get_tenure_block_id -> Result<Option<TenureBlockId>, DBError> with Ok(None) in 172.2s build + 2330.4s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:157:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_burn_block_time_for_block -> Option with Some(0) in 175.8s build + 2323.2s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:196:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_vrf_seed_for_block -> Option<VRFSeed> with None in 182.5s build + 2320.5s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:247:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_burnchain_tokens_spent_for_winning_block -> Option with Some(0) in 152.6s build + 2297.7s test
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:2751:9: replace NakamotoChainState::check_block_commit_vrf_seed -> Result<(), ChainstateError> with Ok(()) in 127.3s build + 2280.3s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:118:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_stacks_block_header_hash_for_block -> Option<BlockHeaderHash> with None in 183.6s build + 2314.1s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:157:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_burn_block_time_for_block -> Option with Some(1) in 178.9s build + 2332.2s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:247:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_burnchain_tokens_spent_for_winning_block -> Option with Some(1) in 187.6s build + 2344.2s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:387:9: replace <impl HeadersDB for ChainstateTx<'a>>::get_burnchain_tokens_spent_for_block -> Option with None in 180.6s build + 2343.5s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:417:9: replace <impl HeadersDB for ChainstateTx<'a>>::get_tokens_earned_for_block -> Option with Some(1) in 145.4s build + 2331.6s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:80:9: replace <impl GetTenureStartId for StacksDBTx<'_>>::get_tenure_block_id -> Result<Option<TenureBlockId>, DBError> with Ok(None) in 200.4s build + 2339.0s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:173:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_stacks_block_time_for_block -> Option with Some(0) in 141.8s build + 2328.5s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:262:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_tokens_earned_for_block -> Option with Some(0) in 184.7s build + 2377.0s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:387:9: replace <impl HeadersDB for ChainstateTx<'a>>::get_burnchain_tokens_spent_for_block -> Option with Some(1) in 198.5s build + 2401.1s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:173:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_stacks_block_time_for_block -> Option with None in 181.6s build + 2341.7s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:219:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_miner_address -> Option<StacksAddress> with None in 180.8s build + 2356.8s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:262:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_tokens_earned_for_block -> Option with None in 196.9s build + 2351.8s test
  • [ ] stackslib/src/clarity_vm/database/mod.rs:387:9: replace <impl HeadersDB for ChainstateTx<'a>>::get_burnchain_tokens_spent_for_block -> Option with Some(0) in 189.5s build + 2312.9s test

ASuciuX avatar Jul 15 '24 12:07 ASuciuX

Unviable Mutants - docs

  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:708:9: replace NakamotoBlockHeader::block_hash -> BlockHeaderHash with Default::default() in 6.8s build
  • [ ] stackslib/src/net/p2p.rs:268:9: replace StacksTipInfo::empty -> Self with Default::default() in 8.2s build
  • [ ] stackslib/src/net/relay.rs:521:9: replace Relayer::get_p2p_handle -> NetworkHandle with Default::default() in 6.7s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:284:9: replace StacksDBIndexed::get_nakamoto_block_id_at_coinbase_height -> Result<Option<StacksBlockId>, DBError> with Ok(Some(Default::default())) in 7.8s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:404:9: replace StacksDBIndexed::get_parent_tenure_consensus_hash -> Result<Option<ConsensusHash>, DBError> with Ok(Some(Default::default())) in 6.7s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:430:9: replace <impl StacksDBIndexed for StacksDBTx<'_>>::sqlite -> &Connection with &Default::default() in 7.5s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:2609:9: replace NakamotoChainState::get_parent_vrf_proof -> Result<VRFProof, ChainstateError> with Ok(Default::default()) in 6.8s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:2926:9: replace NakamotoChainState::advance_tip -> Result<StacksHeaderInfo, ChainstateError> with Ok(Default::default()) in 6.8s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:80:9: replace <impl GetTenureStartId for StacksDBTx<'_>>::get_tenure_block_id -> Result<Option<TenureBlockId>, DBError> with Ok(Some(Default::default())) in 6.9s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:133:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_burn_header_hash_for_block -> Option<BurnchainHeaderHash> with Some(Default::default()) in 6.9s build
  • [ ] stackslib/src/net/p2p.rs:277:9: replace StacksTipInfo::block_id -> StacksBlockId with Default::default() in 7.3s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:343:9: replace StacksDBIndexed::get_highest_block_id_in_tenure -> Result<Option<StacksBlockId>, DBError> with Ok(Some(Default::default())) in 7.1s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:436:9: replace ChainstateTx<'a>::as_tx -> &mut StacksDBTx<'a> with Box::leak(Box::new(Default::default())) in 7.1s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:2503:9: replace NakamotoChainState::get_tenure_start_block_header -> Result<Option<StacksHeaderInfo>, ChainstateError> with Ok(Some(Default::default())) in 7.6s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:3231:9: replace NakamotoChainState::setup_block -> Result<SetupBlockResult<'a, 'b>, ChainstateError> with Ok(Default::default()) in 7.2s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:91:9: replace <impl GetTenureStartId for StacksDBTx<'_>>::conn -> &Connection with &Default::default() in 7.2s build
  • [ ] stackslib/src/net/p2p.rs:4682:9: replace PeerNetwork::get_parent_stacks_tip -> Result<StacksTipInfo, net_error> with Ok(Default::default()) in 7.0s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:300:9: replace StacksDBIndexed::get_tenure_start_block_id -> Result<Option<StacksBlockId>, DBError> with Ok(Some(Default::default())) in 7.8s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:2691:9: replace NakamotoChainState::get_nakamoto_tenure_vrf_proof -> Result<Option<VRFProof>, ChainstateError> with Ok(Some(Default::default())) in 6.8s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:3568:9: replace NakamotoChainState::append_block -> Result<(StacksEpochReceipt, PreCommitClarityBlock<'a>, Option<RewardSetData>,), ChainstateError, > with Ok((Default::default(), Default::default(), None)) in 6.7s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:143:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_consensus_hash_for_block -> Option<ConsensusHash> with Some(Default::default()) in 6.9s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:351:9: replace <impl HeadersDB for ChainstateTx<'a>>::get_vrf_seed_for_block -> Option<VRFSeed> with Some(Default::default()) in 6.6s build
  • [ ] stackslib/src/net/api/get_tenures_fork_info.rs:157:9: replace TenureForkingInfo::from_snapshot -> Result<Self, ChainError> with Ok(Default::default()) in 7.0s build
  • [ ] stackslib/src/net/chat.rs:1727:9: replace ConversationP2P::make_getnakamotoinv_response -> Result<StacksMessageType, net_error> with Ok(Default::default()) in 6.8s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:359:9: replace StacksDBIndexed::get_block_found_tenure_id -> Result<Option<NakamotoTenureEventId>, DBError> with Ok(Some(Default::default())) in 6.6s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:2525:9: replace NakamotoChainState::get_nakamoto_tenure_start_block_header -> Result<Option<StacksHeaderInfo>, ChainstateError> with Ok(Some(Default::default())) in 6.8s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:3568:9: replace NakamotoChainState::append_block -> Result<(StacksEpochReceipt, PreCommitClarityBlock<'a>, Option<RewardSetData>,), ChainstateError, > with Ok((Default::default(), Default::default(), Some(Default::default()))) in 6.8s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:101:9: replace <impl GetTenureStartId for MARF<StacksBlockId>>::get_tenure_block_id -> Result<Option<TenureBlockId>, DBError> with Ok(Some(Default::default())) in 6.9s build
  • [ ] stackslib/src/net/httpcore.rs:1406:9: replace <impl ProtocolFamily for StacksHttp>::stream_payload -> Result<(Option<(StacksHttpMessage, usize)>, usize), NetError> with Ok((Some((Default::default(), 0)), 0)) in 6.6s build
  • [ ] stackslib/src/chainstate/coordinator/mod.rs:284:9: replace <impl From for Error>::from -> Error with Default::default() in 6.8s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:420:9: replace <impl StacksDBIndexed for StacksDBConn<'_>>::sqlite -> &Connection with &Default::default() in 7.2s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:374:9: replace <impl HeadersDB for ChainstateTx<'a>>::get_miner_address -> Option<StacksAddress> with Some(Default::default()) in 7.6s build
  • [ ] stackslib/src/net/httpcore.rs:1406:9: replace <impl ProtocolFamily for StacksHttp>::stream_payload -> Result<(Option<(StacksHttpMessage, usize)>, usize), NetError> with Ok((Some((Default::default(), 0)), 1)) in 6.9s build
  • [ ] stackslib/src/net/p2p.rs:4869:9: replace PeerNetwork::refresh_burnchain_view -> Result<HashMap<NeighborKey, Vec<StacksMessage>>, net_error> with Ok(HashMap::from_iter([(Default::default(), vec![])])) in 7.1s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:2366:9: replace NakamotoChainState::get_header_by_coinbase_height -> Result<Option<StacksHeaderInfo>, ChainstateError> with Ok(Some(Default::default())) in 7.0s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:2541:9: replace NakamotoChainState::get_highest_block_header_in_tenure -> Result<Option<StacksHeaderInfo>, ChainstateError> with Ok(Some(Default::default())) in 7.0s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:196:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_vrf_seed_for_block -> Option<VRFSeed> with Some(Default::default()) in 7.8s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:59:9: replace <impl GetTenureStartId for StacksDBConn<'_>>::get_tenure_block_id -> Result<Option<TenureBlockId>, DBError> with Ok(Some(Default::default())) in 6.8s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:710:5: replace get_matured_reward -> Option<MinerReward> with Some(Default::default()) in 7.4s build
  • [ ] stackslib/src/net/api/gettenureinfo.rs:117:9: replace <impl RPCRequestHandler for RPCNakamotoTenureInfoRequestHandler>::try_handle_request -> Result<(HttpResponsePreamble, HttpResponseContents), NetError> with Ok((Default::default(), Default::default())) in 7.2s build
  • [ ] stackslib/src/net/httpcore.rs:1406:9: replace <impl ProtocolFamily for StacksHttp>::stream_payload -> Result<(Option<(StacksHttpMessage, usize)>, usize), NetError> with Ok((Some((Default::default(), 1)), 0)) in 7.1s build
  • [ ] stackslib/src/net/p2p.rs:4869:9: replace PeerNetwork::refresh_burnchain_view -> Result<HashMap<NeighborKey, Vec<StacksMessage>>, net_error> with Ok(HashMap::from_iter([(Default::default(), vec![Default::default()])])) in 7.0s build
  • [ ] stackslib/src/chainstate/coordinator/mod.rs:3256:9: replace ChainsCoordinator<'a, T, N, U, CE, FE, B>::process_ready_blocks -> Result<Option<BlockHeaderHash>, Error> with Ok(Some(Default::default())) in 7.0s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:70:9: replace <impl GetTenureStartId for StacksDBConn<'_>>::conn -> &Connection with &Default::default() in 7.3s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:118:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_stacks_block_header_hash_for_block -> Option<BlockHeaderHash> with Some(Default::default()) in 7.2s build
  • [ ] stackslib/src/net/httpcore.rs:1406:9: replace <impl ProtocolFamily for StacksHttp>::stream_payload -> Result<(Option<(StacksHttpMessage, usize)>, usize), NetError> with Ok((Some((Default::default(), 1)), 1)) in 6.7s build
  • [ ] stackslib/src/net/p2p.rs:5479:9: replace PeerNetwork::run -> Result<NetworkResult, net_error> with Ok(Default::default()) in 6.9s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:2560:9: replace NakamotoChainState::get_block_vrf_proof -> Result<Option<VRFProof>, ChainstateError> with Ok(Some(Default::default())) in 6.8s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:1691:9: replace NakamotoChainState::process_next_nakamoto_block -> Result<Option<StacksEpochReceipt>, ChainstateError> with Ok(Some(Default::default())) in 6.8s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:506:9: replace <impl HeadersDB for MARF<StacksBlockId>>::get_vrf_seed_for_block -> Option<VRFSeed> with Some(Default::default()) in 8.0s build
  • [ ] stackslib/src/chainstate/nakamoto/mod.rs:330:9: replace StacksDBIndexed::get_ongoing_tenure_id -> Result<Option<NakamotoTenureEventId>, DBError> with Ok(Some(Default::default())) in 7.7s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:106:9: replace <impl GetTenureStartId for MARF<StacksBlockId>>::conn -> &Connection with &Default::default() in 6.7s build
  • [ ] stackslib/src/clarity_vm/database/mod.rs:219:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_miner_address -> Option<StacksAddress> with Some(Default::default()) in 6.9s build

ASuciuX avatar Jul 15 '24 12:07 ASuciuX

Caught Mutants - docs

  • [x] stackslib/src/net/httpcore.rs:794:9: replace StacksHttpRecvStream::consume_data -> Result<(Option<(Vec, usize)>, usize), NetError> with Ok((Some((vec![], 1)), 0)) in 198.2s build + 1023.6s test
  • [x] stackslib/src/net/httpcore.rs:794:9: replace StacksHttpRecvStream::consume_data -> Result<(Option<(Vec, usize)>, usize), NetError> with Ok((Some((vec![1], 1)), 0)) in 121.5s build + 1026.2s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:343:9: replace StacksDBIndexed::get_highest_block_id_in_tenure -> Result<Option<StacksBlockId>, DBError> with Ok(None) in 212.1s build + 66.2s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2187:9: replace NakamotoChainState::store_block_if_better -> Result<bool, ChainstateError> with Ok(true) in 206.0s build + 65.7s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2503:9: replace NakamotoChainState::get_tenure_start_block_header -> Result<Option<StacksHeaderInfo>, ChainstateError> with Ok(None) in 189.3s build + 64.3s test
  • [x] stackslib/src/clarity_vm/database/mod.rs:529:9: replace <impl HeadersDB for MARF<StacksBlockId>>::get_miner_address -> Option<StacksAddress> with None in 172.4s build + 677.8s test
  • [x] stackslib/src/clarity_vm/database/mod.rs:572:9: replace <impl HeadersDB for MARF<StacksBlockId>>::get_tokens_earned_for_block -> Option with None in 183.2s build + 679.1s test
  • [x] stackslib/src/net/httpcore.rs:794:9: replace StacksHttpRecvStream::consume_data -> Result<(Option<(Vec, usize)>, usize), NetError> with Ok((Some((vec![], 1)), 1)) in 207.6s build + 1054.8s test
  • [x] stackslib/src/net/httpcore.rs:794:9: replace StacksHttpRecvStream::consume_data -> Result<(Option<(Vec, usize)>, usize), NetError> with Ok((Some((vec![1], 1)), 1)) in 127.2s build + 1053.7s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:300:9: replace StacksDBIndexed::get_tenure_start_block_id -> Result<Option<StacksBlockId>, DBError> with Ok(None) in 217.0s build + 68.1s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:416:9: replace <impl StacksDBIndexed for StacksDBConn<'_>>::get -> Result<Option<String>, DBError> with Ok(None) in 201.0s build + 68.3s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2187:9: replace NakamotoChainState::store_block_if_better -> Result<bool, ChainstateError> with Ok(false) in 201.5s build + 69.1s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2691:9: replace NakamotoChainState::get_nakamoto_tenure_vrf_proof -> Result<Option<VRFProof>, ChainstateError> with Ok(None) in 196.2s build + 68.3s test
  • [x] stackslib/src/clarity_vm/database/mod.rs:183:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_burn_block_height_for_block -> Option with None in 173.7s build + 122.9s test
  • [x] stackslib/src/net/httpcore.rs:794:9: replace StacksHttpRecvStream::consume_data -> Result<(Option<(Vec, usize)>, usize), NetError> with Ok((Some((vec![0], 0)), 0)) in 198.5s build + 1051.2s test
  • [x] stackslib/src/net/httpcore.rs:1406:9: replace <impl ProtocolFamily for StacksHttp>::stream_payload -> Result<(Option<(StacksHttpMessage, usize)>, usize), NetError> with Ok((None, 0)) in 154.3s build + 1042.6s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:359:9: replace StacksDBIndexed::get_block_found_tenure_id -> Result<Option<NakamotoTenureEventId>, DBError> with Ok(None) in 193.4s build + 69.3s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:416:9: replace <impl StacksDBIndexed for StacksDBConn<'_>>::get -> Result<Option<String>, DBError> with Ok(Some(String::new())) in 188.1s build + 68.7s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2252:9: replace NakamotoChainState::accept_block -> Result<bool, ChainstateError> with Ok(true) in 157.3s build + 68.5s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2525:9: replace NakamotoChainState::get_nakamoto_tenure_start_block_header -> Result<Option<StacksHeaderInfo>, ChainstateError> with Ok(None) in 144.9s build + 68.0s test
  • [x] stackslib/src/clarity_vm/database/mod.rs:542:9: replace <impl HeadersDB for MARF<StacksBlockId>>::get_burnchain_tokens_spent_for_block -> Option with None in 179.7s build + 682.3s test
  • [x] stackslib/src/clarity_vm/database/mod.rs:572:9: replace <impl HeadersDB for MARF<StacksBlockId>>::get_tokens_earned_for_block -> Option with Some(1) in 179.1s build + 695.4s test
  • [x] stackslib/src/net/httpcore.rs:794:9: replace StacksHttpRecvStream::consume_data -> Result<(Option<(Vec, usize)>, usize), NetError> with Ok((Some((vec![0], 0)), 1)) in 191.0s build + 1054.8s test
  • [x] stackslib/src/net/httpcore.rs:1406:9: replace <impl ProtocolFamily for StacksHttp>::stream_payload -> Result<(Option<(StacksHttpMessage, usize)>, usize), NetError> with Ok((None, 1)) in 160.8s build + 1052.8s test
  • [x] stackslib/src/net/relay.rs:807:9: replace Relayer::process_new_nakamoto_block -> Result<bool, chainstate_error> with Ok(false) in 191.8s build + 66.0s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:316:9: replace StacksDBIndexed::get_coinbase_height -> Result<Option, DBError> with Ok(None) in 200.1s build + 66.2s test
  • [x] stackslib/src/net/relay.rs:807:9: replace Relayer::process_new_nakamoto_block -> Result<bool, chainstate_error> with Ok(true) in 197.6s build + 68.7s test
  • [x] stackslib/src/clarity_vm/database/mod.rs:183:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_burn_block_height_for_block -> Option with Some(0) in 176.5s build + 136.4s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:416:9: replace <impl StacksDBIndexed for StacksDBConn<'_>>::get -> Result<Option<String>, DBError> with Ok(Some("xyzzy".into())) in 198.2s build + 68.0s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2252:9: replace NakamotoChainState::accept_block -> Result<bool, ChainstateError> with Ok(false) in 202.7s build + 66.8s test
  • [x] stackslib/src/clarity_vm/database/mod.rs:157:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_burn_block_time_for_block -> Option with None in 182.6s build + 446.4s test
  • [x] stackslib/src/clarity_vm/database/mod.rs:183:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_burn_block_height_for_block -> Option with Some(1) in 175.5s build + 136.0s test
  • [x] stackslib/src/net/httpcore.rs:794:9: replace StacksHttpRecvStream::consume_data -> Result<(Option<(Vec, usize)>, usize), NetError> with Ok((None, 0)) in 187.0s build + 1002.8s test
  • [x] stackslib/src/net/httpcore.rs:794:9: replace StacksHttpRecvStream::consume_data -> Result<(Option<(Vec, usize)>, usize), NetError> with Ok((Some((vec![0], 1)), 0)) in 132.1s build + 1006.8s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2727:9: replace NakamotoChainState::get_coinbase_height -> Result<Option, ChainstateError> with Ok(None) in 180.8s build + 68.1s test
  • [x] stackslib/src/net/p2p.rs:4869:9: replace PeerNetwork::refresh_burnchain_view -> Result<HashMap<NeighborKey, Vec<StacksMessage>>, net_error> with Ok(HashMap::new()) in 201.4s build + 62.6s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:316:9: replace StacksDBIndexed::get_coinbase_height -> Result<Option, DBError> with Ok(Some(0)) in 211.4s build + 64.9s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:375:9: replace StacksDBIndexed::is_tenure_finished -> Result<Option, DBError> with Ok(None) in 192.2s build + 65.3s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2366:9: replace NakamotoChainState::get_header_by_coinbase_height -> Result<Option<StacksHeaderInfo>, ChainstateError> with Ok(None) in 198.4s build + 65.0s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2541:9: replace NakamotoChainState::get_highest_block_header_in_tenure -> Result<Option<StacksHeaderInfo>, ChainstateError> with Ok(None) in 132.4s build + 64.8s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2727:9: replace NakamotoChainState::get_coinbase_height -> Result<Option, ChainstateError> with Ok(Some(0)) in 158.3s build + 65.2s test
  • [x] stackslib/src/chainstate/coordinator/mod.rs:3256:9: replace ChainsCoordinator<'a, T, N, U, CE, FE, B>::process_ready_blocks -> Result<Option<BlockHeaderHash>, Error> with Ok(None) in 197.0s build + 33.5s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:316:9: replace StacksDBIndexed::get_coinbase_height -> Result<Option, DBError> with Ok(Some(1)) in 201.9s build + 67.2s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:375:9: replace StacksDBIndexed::is_tenure_finished -> Result<Option, DBError> with Ok(Some(true)) in 195.5s build + 66.5s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:426:9: replace <impl StacksDBIndexed for StacksDBTx<'_>>::get -> Result<Option<String>, DBError> with Ok(None) in 190.8s build + 67.1s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:1293:9: replace NakamotoBlock::validate_vrf_seed -> Result<(), ChainstateError> with Ok(()) in 171.5s build + 66.7s test
  • [x] stackslib/src/net/httpcore.rs:794:9: replace StacksHttpRecvStream::consume_data -> Result<(Option<(Vec, usize)>, usize), NetError> with Ok((None, 1)) in 192.4s build + 1048.7s test
  • [x] stackslib/src/net/httpcore.rs:794:9: replace StacksHttpRecvStream::consume_data -> Result<(Option<(Vec, usize)>, usize), NetError> with Ok((Some((vec![0], 1)), 1)) in 136.2s build + 1034.8s test
  • [x] stackslib/src/net/httpcore.rs:794:9: replace StacksHttpRecvStream::consume_data -> Result<(Option<(Vec, usize)>, usize), NetError> with Ok((Some((vec![], 0)), 0)) in 191.2s build + 1024.1s test
  • [x] stackslib/src/net/httpcore.rs:794:9: replace StacksHttpRecvStream::consume_data -> Result<(Option<(Vec, usize)>, usize), NetError> with Ok((Some((vec![1], 0)), 0)) in 122.3s build + 1026.4s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:330:9: replace StacksDBIndexed::get_ongoing_tenure_id -> Result<Option<NakamotoTenureEventId>, DBError> with Ok(None) in 215.0s build + 66.3s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:375:9: replace StacksDBIndexed::is_tenure_finished -> Result<Option, DBError> with Ok(Some(false)) in 189.2s build + 66.6s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:426:9: replace <impl StacksDBIndexed for StacksDBTx<'_>>::get -> Result<Option<String>, DBError> with Ok(Some(String::new())) in 190.4s build + 66.2s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:1691:9: replace NakamotoChainState::process_next_nakamoto_block -> Result<Option<StacksEpochReceipt>, ChainstateError> with Ok(None) in 191.7s build + 65.9s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2467:9: replace NakamotoChainState::has_block_header_epoch2 -> Result<bool, ChainstateError> with Ok(true) in 198.9s build + 89.9s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2560:9: replace NakamotoChainState::get_block_vrf_proof -> Result<Option<VRFProof>, ChainstateError> with Ok(None) in 184.8s build + 65.7s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2727:9: replace NakamotoChainState::get_coinbase_height -> Result<Option, ChainstateError> with Ok(Some(1)) in 161.6s build + 66.7s test
  • [x] stackslib/src/clarity_vm/database/mod.rs:557:9: replace <impl HeadersDB for MARF<StacksBlockId>>::get_burnchain_tokens_spent_for_winning_block -> Option with None in 185.4s build + 675.8s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2794:9: replace NakamotoChainState::insert_stacks_block_header -> Result<(), ChainstateError> with Ok(()) in 199.2s build + 66.1s test
  • [x] stackslib/src/clarity_vm/database/mod.rs:133:9: replace <impl HeadersDB for HeadersDBConn<'a>>::get_burn_header_hash_for_block -> Option<BurnchainHeaderHash> with None in 184.0s build + 434.6s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:284:9: replace StacksDBIndexed::get_nakamoto_block_id_at_coinbase_height -> Result<Option<StacksBlockId>, DBError> with Ok(None) in 212.3s build + 66.6s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:404:9: replace StacksDBIndexed::get_parent_tenure_consensus_hash -> Result<Option<ConsensusHash>, DBError> with Ok(None) in 138.0s build + 66.1s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:426:9: replace <impl StacksDBIndexed for StacksDBTx<'_>>::get -> Result<Option<String>, DBError> with Ok(Some("xyzzy".into())) in 194.2s build + 66.4s test
  • [x] stackslib/src/clarity_vm/database/mod.rs:557:9: replace <impl HeadersDB for MARF<StacksBlockId>>::get_burnchain_tokens_spent_for_winning_block -> Option with Some(1) in 183.0s build + 686.8s test
  • [x] stackslib/src/core/mempool.rs:1628:9: replace MemPoolDB::iterate_candidates -> Result<u64, E> with Ok(1) in 205.6s build + 718.9s test
  • [x] stackslib/src/chainstate/nakamoto/mod.rs:2467:9: replace NakamotoChainState::has_block_header_epoch2 -> Result<bool, ChainstateError> with Ok(false) in 183.9s build + 66.0s test
  • [x] stackslib/src/net/httpcore.rs:794:9: replace StacksHttpRecvStream::consume_data -> Result<(Option<(Vec, usize)>, usize), NetError> with Ok((Some((vec![], 0)), 1)) in 192.2s build + 1027.9s test
  • [x] stackslib/src/net/httpcore.rs:794:9: replace StacksHttpRecvStream::consume_data -> Result<(Option<(Vec, usize)>, usize), NetError> with Ok((Some((vec![1], 0)), 1)) in 120.9s build + 1021.5s test

ASuciuX avatar Jul 15 '24 12:07 ASuciuX

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 19 '25 05:07 stale[bot]