stacks-core icon indicating copy to clipboard operation
stacks-core copied to clipboard

warn for not using local stacks node with the signer

Open ASuciuX opened this issue 9 months ago • 3 comments

  • fixes https://github.com/stacks-network/stacks-core/issues/4730

Example display of message. Do we want to place it on only one line? Maybe make the message shorter.

image

ASuciuX avatar May 13 '24 13:05 ASuciuX

I think it could potentially cause more harm (or at least worry) than good if we're being strict about this warning with non-localhost setups. IMO it's probably best practice to have these two services on separate colocated machines, or at most using something like docker-compose, but we wouldn't really be able to check that. The main risk is that the signer isn't a registered event_observer, and that's easy to mess up if you're using an external node, but we don't have a good way of verifying that the signer is an event observer.

hstove avatar May 13 '24 17:05 hstove

I think it could potentially cause more harm (or at least worry) than good if we're being strict about this warning with non-localhost setups. IMO it's probably best practice to have these two services on separate colocated machines, or at most using something like docker-compose, but we wouldn't really be able to check that. The main risk is that the signer isn't a registered event_observer, and that's easy to mess up if you're using an external node, but we don't have a good way of verifying that the signer is an event observer.

Well the warning is mostly in response to the audit as we are susecptible to man in the middle type situations so perhaps we should just always print it then.

jferrant avatar May 13 '24 21:05 jferrant

Updated message displayed after having all of it as 1 line

image

ASuciuX avatar May 13 '24 22:05 ASuciuX