stacks-core icon indicating copy to clipboard operation
stacks-core copied to clipboard

Published 20 hours ago • verified publisher icon stacks-network

Fix/4732

Open jcnelson opened this issue 1 year ago • 5 comments

This fixes #4732 by tracking pending connections in addition to completed connections, so that the state machine for StackerDB doesn't re-attempt a handshake if it already has one in-flight. It also disables disconnection from dead/broken StackerDB peers, since a StackerDB peer's inability to reply to a StackerDB request (itself a best-effort replication system) should not be grounds for disconnecting from and banning the node in its entirety.

jcnelson avatar May 08 '24 01:05 jcnelson

Okay, I have this running on my node, and have tested it in both IBD and steady-state modes of operation. No duplicate connections have been established.

jcnelson avatar May 09 '24 16:05 jcnelson

ping @kantai

jcnelson avatar May 10 '24 21:05 jcnelson

(note that this is blocking the next point release)

jcnelson avatar May 10 '24 21:05 jcnelson

@kantai I added some regression tests for the new functionality

jcnelson avatar May 13 '24 20:05 jcnelson

There are some build issues with the latest version.

obycode avatar May 14 '24 00:05 obycode