stacks-core icon indicating copy to clipboard operation
stacks-core copied to clipboard

Attempt to fix bitcoin reorg flap test

Open obycode opened this issue 1 year ago • 3 comments

Forcefully kill the bitcoind in case it fails to stop.

obycode avatar Mar 28 '24 02:03 obycode

It looks like some change in between the original fix to this problem and the current next has caused the test to fail, so that needs to get fixed. I'll look into it tomorrow.

obycode avatar Mar 28 '24 02:03 obycode

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 77.80%. Comparing base (9708368) to head (a4b5295). Report is 27 commits behind head on next.

Files with missing lines Patch % Lines
testnet/stacks-node/src/tests/neon_integrations.rs 0.00% 40 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (9708368) and HEAD (a4b5295). Click for more details.

HEAD has 69 uploads less than BASE
Flag BASE (9708368) HEAD (a4b5295)
133 64
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4601      +/-   ##
==========================================
- Coverage   83.39%   77.80%   -5.59%     
==========================================
  Files         470      470              
  Lines      332704   332804     +100     
  Branches      317      317              
==========================================
- Hits       277442   258940   -18502     
- Misses      55254    73856   +18602     
  Partials        8        8              
Files with missing lines Coverage Δ
testnet/stacks-node/src/tests/neon_integrations.rs 68.73% <0.00%> (-4.73%) :arrow_down:

... and 183 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9708368...a4b5295. Read the comment docs.

codecov[bot] avatar Apr 03 '24 14:04 codecov[bot]

this PR still needs more work. brice and I have discussed some alternatives but it may not be ready for 2.5.

i would recommend we move this to draft/backlog for now

wileyj avatar Apr 05 '24 17:04 wileyj

@obycode Can we close this? I think you got this working recently by using an RPC to bitcoind to make it stop?

jcnelson avatar Sep 24 '24 14:09 jcnelson

Yes, this was fixed by #5207.

obycode avatar Sep 24 '24 14:09 obycode