stacks-core icon indicating copy to clipboard operation
stacks-core copied to clipboard

Initial changes for including rewardSet in new block event

Open 8marz8 opened this issue 1 year ago • 1 comments

Description

This PR includes RewardSet data in new_block events instead of broadcasting a separate event.

Note: This Draft PR is not completed and only has the initial tweaks to confirm the approach.

Applicable issues

  • closes #4407

8marz8 avatar Feb 27 '24 02:02 8marz8

Codecov Report

Attention: Patch coverage is 87.40741% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 77.62%. Comparing base (04e5eb2) to head (242264e). Report is 4 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4430      +/-   ##
==========================================
- Coverage   83.23%   77.62%   -5.62%     
==========================================
  Files         451      451              
  Lines      325724   325766      +42     
  Branches      323      323              
==========================================
- Hits       271125   252875   -18250     
- Misses      54591    72883   +18292     
  Partials        8        8              
Files Coverage Δ
stackslib/src/chainstate/coordinator/mod.rs 61.53% <ø> (-0.05%) :arrow_down:
stackslib/src/net/mod.rs 72.87% <100.00%> (-0.17%) :arrow_down:
testnet/stacks-node/src/config.rs 56.53% <ø> (-7.22%) :arrow_down:
testnet/stacks-node/src/event_dispatcher.rs 83.00% <100.00%> (-2.76%) :arrow_down:
testnet/stacks-node/src/run_loop/mod.rs 99.18% <100.00%> (+<0.01%) :arrow_up:
stackslib/src/chainstate/coordinator/tests.rs 84.70% <0.00%> (-6.00%) :arrow_down:
stackslib/src/chainstate/stacks/boot/mod.rs 90.58% <85.71%> (-4.18%) :arrow_down:
stackslib/src/main.rs 0.06% <0.00%> (ø)
stackslib/src/chainstate/stacks/db/blocks.rs 85.14% <93.93%> (-4.78%) :arrow_down:
stackslib/src/chainstate/nakamoto/mod.rs 83.13% <80.00%> (-0.32%) :arrow_down:
... and 1 more

... and 159 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04e5eb2...242264e. Read the comment docs.

codecov[bot] avatar Feb 27 '24 02:02 codecov[bot]