stacks-core icon indicating copy to clipboard operation
stacks-core copied to clipboard

chore: Remove imports already included by `std::prelude`

Open jbencin opened this issue 1 year ago • 1 comments

Description

Remove all imports already included by std::prelude as of Rust Edition 2021. Deletes about 150 lines from the codebase

Additional info (benefits, drawbacks, caveats)

This PR does nothing other than remove use statements. Since the binaries and tests still build, it's obviously safe to merge

jbencin avatar Feb 17 '24 03:02 jbencin

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.37%. Comparing base (9385b42) to head (76268b4).

Additional details and impacted files
@@             Coverage Diff             @@
##             next    #4390       +/-   ##
===========================================
- Coverage   83.41%   66.37%   -17.04%     
===========================================
  Files         448      448               
  Lines      323930   323930               
===========================================
- Hits       270197   215016    -55181     
- Misses      53733   108914    +55181     
Files Coverage Δ
clarity/src/libclarity.rs 39.28% <ø> (ø)
clarity/src/vm/analysis/type_checker/v2_05/mod.rs 89.85% <ø> (-1.00%) :arrow_down:
.../src/vm/analysis/type_checker/v2_05/natives/mod.rs 90.90% <ø> (-0.53%) :arrow_down:
...m/analysis/type_checker/v2_05/natives/sequences.rs 93.98% <ø> (-0.38%) :arrow_down:
...src/vm/analysis/type_checker/v2_05/tests/assets.rs 0.00% <ø> (-100.00%) :arrow_down:
...ty/src/vm/analysis/type_checker/v2_05/tests/mod.rs 65.93% <ø> (-33.98%) :arrow_down:
clarity/src/vm/analysis/type_checker/v2_1/mod.rs 89.00% <ø> (-0.70%) :arrow_down:
...y/src/vm/analysis/type_checker/v2_1/natives/mod.rs 90.47% <ø> (-0.67%) :arrow_down:
...vm/analysis/type_checker/v2_1/natives/sequences.rs 93.97% <ø> (-1.68%) :arrow_down:
.../src/vm/analysis/type_checker/v2_1/tests/assets.rs 100.00% <ø> (ø)
... and 104 more

... and 184 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9385b42...76268b4. Read the comment docs.

codecov[bot] avatar Feb 17 '24 04:02 codecov[bot]