stacks-core
stacks-core copied to clipboard
feat: burn op definition and storage for vote-for-agg-key
Based on my notes in this discussion, this PR implements a burn op for vote-for-aggregate-key
.
This PR is currently a work in progress. The code exists for parsing and storing this new burn op, but I've yet to actually process the burn op by making a Clarity tx.
This is built on top of #4360, because that PR has the updated function signature for vote-for-aggregate-public-key
.
- closes https://github.com/stacks-network/stacks-core/issues/4272
Codecov Report
Attention: Patch coverage is 92.28371%
with 99 lines
in your changes are missing coverage. Please review.
Project coverage is 83.28%. Comparing base (
067633d
) to head (e3a76f7
). Report is 34 commits behind head on next.
Additional details and impacted files
@@ Coverage Diff @@
## next #4376 +/- ##
==========================================
+ Coverage 83.22% 83.28% +0.05%
==========================================
Files 452 453 +1
Lines 326058 327328 +1270
Branches 323 323
==========================================
+ Hits 271359 272610 +1251
- Misses 54691 54710 +19
Partials 8 8
Files | Coverage Δ | |
---|---|---|
stackslib/src/burnchains/bitcoin/bits.rs | 94.03% <100.00%> (ø) |
|
stackslib/src/chainstate/burn/db/sortdb.rs | 91.94% <100.00%> (+0.09%) |
:arrow_up: |
...c/chainstate/burn/operations/test/serialization.rs | 100.00% <100.00%> (ø) |
|
stackslib/src/chainstate/nakamoto/mod.rs | 83.47% <100.00%> (+0.06%) |
:arrow_up: |
stackslib/src/chainstate/stacks/db/accounts.rs | 91.50% <100.00%> (+<0.01%) |
:arrow_up: |
stackslib/src/chainstate/stacks/db/mod.rs | 84.19% <100.00%> (+0.05%) |
:arrow_up: |
stackslib/src/net/mod.rs | 72.91% <ø> (-0.05%) |
:arrow_down: |
stackslib/src/chainstate/burn/mod.rs | 94.19% <0.00%> (-0.25%) |
:arrow_down: |
stackslib/src/chainstate/burn/db/processing.rs | 86.47% <33.33%> (-0.92%) |
:arrow_down: |
...t/stacks-node/src/burnchains/mocknet_controller.rs | 71.24% <0.00%> (-1.89%) |
:arrow_down: |
... and 7 more |
... and 18 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 067633d...e3a76f7. Read the comment docs.
Ok, finally figured out why my Nakamoto integration test was failing. Ready for reviews now @obycode @8marz8 @setzeus