stacks-core icon indicating copy to clipboard operation
stacks-core copied to clipboard

feat: add devnet tweaks

Open hugocaillard opened this issue 1 year ago • 3 comments

Description

wip

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • [ ] Test coverage for new or modified code paths
  • [ ] Changelog is updated
  • [ ] Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • [ ] New clarity functions have corresponding PR in clarity-benchmarking repo
  • [ ] New integration test(s) added to bitcoin-tests.yml

hugocaillard avatar Jan 09 '24 10:01 hugocaillard

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (9690ecd) 59.40% compared to head (ae1fb3f) 19.77%.

Files Patch % Lines
testnet/stacks-node/src/config.rs 50.00% 5 Missing :warning:
testnet/stacks-node/src/nakamoto_node/relayer.rs 0.00% 3 Missing :warning:
stackslib/src/burnchains/bitcoin/indexer.rs 66.66% 1 Missing :warning:
...-node/src/burnchains/bitcoin_regtest_controller.rs 50.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             next    #4234       +/-   ##
===========================================
- Coverage   59.40%   19.77%   -39.64%     
===========================================
  Files         446      446               
  Lines      318774   318784       +10     
===========================================
- Hits       189381    63041   -126340     
- Misses     129393   255743   +126350     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 09 '24 11:01 codecov[bot]

Can you explain the reason for changing the constants you did in the PR description? I'm not objecting to the changes, I just don't understand them well

jbencin avatar Jan 23 '24 20:01 jbencin

Hey @jbencin This PR is still quite drafty, I haven't self-reviewed and it's mostly code that I didn't write myself. I'll update the description before switching to ready for review

hugocaillard avatar Jan 23 '24 21:01 hugocaillard