Fix Warnings

[donpdonp]

Description

Fixes compiler warnings. Changed unused struct fields from name to _name.

Applicable issues

• fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

• [ ] Test coverage for new or modified code paths
• [ ] Changelog is updated
• [ ] Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• [ ] New clarity functions have corresponding PR in clarity-benchmarking repo
• [ ] New integration test(s) added to bitcoin-tests.yml

[CLAassistant]

All committers have signed the CLA.

[codecov[bot]]

Codecov Report

Merging #3298 (c9941ec) into master (3e8a917) will decrease coverage by 42.55%. The diff coverage is 27.27%.

@@             Coverage Diff             @@
##           master    #3298       +/-   ##
===========================================
- Coverage   73.52%   30.97%   -42.56%     
===========================================
  Files         260      262        +2     
  Lines      206266   206308       +42     
===========================================
- Hits       151660    63903    -87757     
- Misses      54606   142405    +87799     

Impacted Files	Coverage Δ
src/chainstate/burn/db/sortdb.rs	37.76% <0.00%> (-56.58%)	:arrow_down:
src/chainstate/stacks/db/mod.rs	73.20% <0.00%> (-13.65%)	:arrow_down:
src/chainstate/stacks/miner.rs	12.84% <ø> (-76.96%)	:arrow_down:
...-node/src/burnchains/bitcoin_regtest_controller.rs	86.22% <ø> (+84.77%)	:arrow_up:
testnet/stacks-node/src/config.rs	48.63% <0.00%> (+10.00%)	:arrow_up:
testnet/stacks-node/src/keychain.rs	90.00% <ø> (+14.84%)	:arrow_up:
testnet/stacks-node/src/main.rs	0.54% <0.00%> (+<0.01%)	:arrow_up:
testnet/stacks-node/src/neon_node.rs	77.61% <0.00%> (+77.61%)	:arrow_up:
testnet/stacks-node/src/syncctl.rs	25.70% <ø> (+25.70%)	:arrow_up:
src/chainstate/stacks/index/storage.rs	70.94% <100.00%> (-7.01%)	:arrow_down:
... and 242 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jcnelson]

Looks like we got some compile errors.

[donpdonp]

On my laptop with the same commit hashes as the code-cov report "Merging #3298 (acc120f) into master (3e8a917)", cargo build completes with no warnings or errors. So I'm trying to figure out how the setup for this PR is leading to those std::fs errors.

[donpdonp]

The warnings and errors are cleaned up - the difference was due to rust 1.64 in CI and 1.63 on my laptop. I thought about changing rust-toolchain to "1.64" but a) the changes also work in 1.63 b) there isn't a way to say 1.64 "and higher", so it remains at 'stable'.

There were two checks called build-publish- and they failed for want of a docker hub username and password. Whats the fix for those steps?

[donpdonp]

closing this and re-creating for next branch