stacks-core
stacks-core copied to clipboard
chore: force runtime panics due to errors other than invalid blocks or microblocks
Update append_block()
and its dependent methods so that errors in block processing due to reasons other than blocks or microblocks being invalid all trigger runtime panics.
Leaving as a draft for now so I can test it live.
Codecov Report
Merging #3108 (62880d0) into develop (d2f31ca) will increase coverage by
0.02%
. The diff coverage is81.33%
.
@@ Coverage Diff @@
## develop #3108 +/- ##
===========================================
+ Coverage 83.71% 83.74% +0.02%
===========================================
Files 260 260
Lines 200932 200963 +31
===========================================
+ Hits 168210 168289 +79
+ Misses 32722 32674 -48
Impacted Files | Coverage Δ | |
---|---|---|
src/chainstate/stacks/db/blocks.rs | 89.24% <74.54%> (+0.19%) |
:arrow_up: |
src/chainstate/stacks/db/mod.rs | 87.24% <100.00%> (+0.27%) |
:arrow_up: |
clarity/src/vm/database/sqlite.rs | 78.47% <0.00%> (-1.39%) |
:arrow_down: |
src/net/atlas/download.rs | 82.38% <0.00%> (-1.29%) |
:arrow_down: |
clarity/src/vm/analysis/errors.rs | 69.50% <0.00%> (-0.50%) |
:arrow_down: |
src/burnchains/bitcoin/blocks.rs | 92.37% <0.00%> (-0.41%) |
:arrow_down: |
src/burnchains/burnchain.rs | 90.31% <0.00%> (-0.39%) |
:arrow_down: |
clarity/src/vm/database/key_value_wrapper.rs | 96.51% <0.00%> (-0.32%) |
:arrow_down: |
src/net/inv.rs | 70.57% <0.00%> (-0.30%) |
:arrow_down: |
src/burnchains/bitcoin/indexer.rs | 84.21% <0.00%> (-0.22%) |
:arrow_down: |
... and 22 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d2f31ca...62880d0. Read the comment docs.