stacks-core icon indicating copy to clipboard operation
stacks-core copied to clipboard

Check if CircleCi is still used

Open wileyj opened this issue 3 years ago • 4 comments

from readme, circleci image is 404'ing https://circleci.com/gh/blockstack/stacks-blockchain/tree/master. Is this CI tool still used ? i see the circleci yaml, and a Dockerfile but there's no action using them and the circle links are not working https://github.com/stacks-network/stacks-blockchain#stacks-20

TODO: check if circleci is still in use. if yes, update links etc in the readme. if not in use, then we can remove all references to circleci and Hiro can disable any jobs still there.

wileyj avatar Mar 14 '22 15:03 wileyj

Consensus here is "no." CircleCI invoked our unit tests using cargo test --workspace, whereas previously unit tests in GH actions invoked cargo test. But because develop broke the workspace into more modules, GH needed to invoke cargo test --workspace anyway, so CircleCI doesn't do anything useful for us anymore. We can remove CircleCI support in the next release (or even now).

jcnelson avatar Mar 21 '22 16:03 jcnelson

@igorsyl

wileyj avatar Jun 22 '22 21:06 wileyj

The last activity on https://app.circleci.com/pipelines/github/stacks-network/stacks-blockchain was 3 months ago. Is it safe to cancel the paid plan (which Hiro is currently paying for) and close this issue? cc/ @jcnelson @kantai

diwakergupta avatar Jun 29 '22 19:06 diwakergupta

Yes, let's close it.

kantai avatar Jun 29 '22 19:06 kantai

Should this file be deleted before we close this issue?

https://github.com/stacks-network/stacks-blockchain/blob/master/circle.yml

kantai avatar Feb 22 '23 19:02 kantai

Nothing has run on CircleCI for ~11mo, so yeah let's do it. I'm happy to take this on ;)

diwakergupta avatar Feb 22 '23 19:02 diwakergupta