stacks-core
stacks-core copied to clipboard
fix: remove blocks and microblocks from requested status if the connection times out
This will prevent a block or microblock download from stalling for ~1 minute if the request times out.
Codecov Report
Merging #3050 (8c47ede) into develop (30890c6) will decrease coverage by
0.09%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## develop #3050 +/- ##
===========================================
- Coverage 83.83% 83.74% -0.10%
===========================================
Files 248 248
Lines 196916 196934 +18
===========================================
- Hits 165090 164914 -176
- Misses 31826 32020 +194
Impacted Files | Coverage Δ | |
---|---|---|
src/net/download.rs | 41.02% <0.00%> (-0.28%) |
:arrow_down: |
...ommon/src/deps_common/bitcoin/network/serialize.rs | 44.00% <0.00%> (-4.00%) |
:arrow_down: |
src/burnchains/bitcoin/mod.rs | 37.68% <0.00%> (-2.90%) |
:arrow_down: |
testnet/stacks-node/src/tests/neon_integrations.rs | 88.34% <0.00%> (-2.08%) |
:arrow_down: |
src/burnchains/bitcoin/indexer.rs | 83.24% <0.00%> (-1.54%) |
:arrow_down: |
src/cost_estimates/mod.rs | 47.48% <0.00%> (-0.72%) |
:arrow_down: |
clarity/src/vm/analysis/errors.rs | 69.50% <0.00%> (-0.50%) |
:arrow_down: |
src/net/p2p.rs | 58.06% <0.00%> (-0.44%) |
:arrow_down: |
src/chainstate/stacks/index/storage.rs | 79.66% <0.00%> (-0.38%) |
:arrow_down: |
src/chainstate/coordinator/mod.rs | 92.34% <0.00%> (-0.32%) |
:arrow_down: |
... and 22 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a1d45ca...8c47ede. Read the comment docs.
This change looks fine to me, but is this possible to test via a unit test? Also, this should get a changelog entry.