sbtc-developer-release
sbtc-developer-release copied to clipboard
Stacks-explorer fails to compile
Summary of Changes
CI has been failing lately. These changes fixed it for me. I ported the changes from the Hiro dockerfile for stacks-explorer.
Evidence: https://github.com/stacks-network/sbtc/actions/runs/6578085435/job/18167621690?pr=303
Testing
Risks
How were these changes tested?
Locally and in CI for open PRs.
What future testing should occur?
Checklist:
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6470223
) 43.44% compared to head (24782a6
) 43.44%. Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #350 +/- ##
=======================================
Coverage 43.44% 43.44%
=======================================
Files 45 45
Lines 5467 5467
Branches 47 47
=======================================
Hits 2375 2375
Misses 3091 3091
Partials 1 1
Flag | Coverage Δ | |
---|---|---|
unittests | 76.61% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@AshtonStephens who else can review this?