sbtc-developer-release
sbtc-developer-release copied to clipboard
Increase stacks client coverage
Summary of Changes
Refactored error handling and added tests.
Testing
Risks
I touched on a few methods without tests. It could have changed the behavior slightly. I checked that none of the callers relied on the old logic, but I could have missed something.
How were these changes tested?
Static analysis and added unit tests.
What future testing should occur?
Checklist:
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my code
- [X] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
Codecov Report
Attention: 118 lines
in your changes are missing coverage. Please review.
Comparison is base (
6470223
) 43.44% compared to head (76bcb4c
) 47.85%. Report is 4 commits behind head on main.
:exclamation: Current head 76bcb4c differs from pull request most recent head 41990f1. Consider uploading reports for the commit 41990f1 to get more accurate results
Files | Patch % | Lines |
---|---|---|
romeo/src/stacks_client.rs | 68.45% | 94 Missing :warning: |
romeo/src/system.rs | 0.00% | 24 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #347 +/- ##
==========================================
+ Coverage 43.44% 47.85% +4.41%
==========================================
Files 45 45
Lines 5467 5567 +100
Branches 47 47
==========================================
+ Hits 2375 2664 +289
+ Misses 3091 2902 -189
Partials 1 1
Flag | Coverage Δ | |
---|---|---|
unittests | 76.61% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.