sbtc-developer-release
sbtc-developer-release copied to clipboard
Add manual workflow to deploy docker images to blockstack
Summary of Changes
Add manual docker image publishing
Testing
Risks
Few risks. It could provide faulty images and make people believe their code is broken when it's just the images.
How were these changes tested?
Tested on an x86 computer. Has issues with ARM64
What future testing should occur?
Should find a way to generate arm64 images.
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any dependent changes have been merged and published in downstream modules
How would this play out locally if we pull some changes, try spinning up devenv and the images are not built yet in the CI?
It would play out poorly - you would need to run ./build.sh
locally to overwrite the ones here. For most users, this will be fine.
It might be worth making a separate devenv
repo that doesn't only pulls in the images. At a point, our code should be stable
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
66e9238
) 41.03% compared to head (a906eec
) 42.70%. Report is 25 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #285 +/- ##
==========================================
+ Coverage 41.03% 42.70% +1.66%
==========================================
Files 40 45 +5
Lines 5042 5290 +248
Branches 0 47 +47
==========================================
+ Hits 2069 2259 +190
- Misses 2973 3030 +57
- Partials 0 1 +1
Flag | Coverage Δ | |
---|---|---|
unittests | 76.61% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Is this good to merge?
@AshtonStephens This is still helpful for devenv when using nakamoto. Can we have docker images for the current state of stacks-blockchain node?