blockstack-browser icon indicating copy to clipboard operation
blockstack-browser copied to clipboard

UI error: logo not added in pre-release v0.36.1

Open thinkverse opened this issue 6 years ago • 6 comments
trafficstars

Error while trying to use the following icon from the Manifest: http://localhost:8888/static/images/app-blockstack.png (Download error or resource isn't a valid image)

Someone forgot to add the Blockstack logo to the v0.36.1 pre-release so the browser tries to fetch something that doesn't exist anymore, so someone that has it, please add it to the static images folder before a proper release.

thinkverse avatar Apr 08 '19 15:04 thinkverse

Thanks @thinkverse for this report! We're meeting to Browser needs tomorrow so will make sure to discuss this bug and assign for resolution quickly.

markmhendrickson avatar Apr 08 '19 15:04 markmhendrickson

Since your here, the favicon doesn't seem to be working either, seems the server isn't returning it even though it's in the folder structure.

thinkverse avatar Apr 08 '19 15:04 thinkverse

Hey @thinkverse , can you explain where this image is being loaded? Is this your app's icon?

hstove avatar Apr 08 '19 17:04 hstove

No, not mine, it's being requested because of the Blockstack browser's manifest.json, inside icons it's requesting;

"icons": [{
  "src": "/static/images/app-blockstack.png",
  "sizes": "128x128",
  "type": "image/png"
}]

which isn't added to the pre-release build, causing an error to be thrown, after I downladed the image and added it to the programs static folder the error went away, so the app/images/app-blockstack.png is not being pushed to the final build.

thinkverse avatar Apr 08 '19 17:04 thinkverse

@markmhx this is still a problem when testing with the local client. Working with the hello-world the manifest is:

{
  "name": "Hello, Blockstack",
  "start_url": "localhost:5000",
  "description": "A simple demo of Blockstack Auth",
  "icons": [{
    "src": "favicon.ico",
    "sizes": "192x192",
    "type": "image/png"
  }]
}

This works fine when opening with the webapp:

image

But fails when opening the same hello-world with our client.

image

The client isn't picking up the icon despite the fact this is our generated sample.

moxiegirl avatar Aug 07 '19 17:08 moxiegirl

@hstove Is this bug one we can fix implicitly as part of the rebuild?

markmhendrickson avatar Jan 21 '20 13:01 markmhendrickson