collector
collector copied to clipboard
Runs tests based on capabilities of the image
Description
Instead of running the tests based on labels provided in a PR, we can inspect the built image and check which architectures it supports and test based on that information. It effectively decouples the tests from the builds, and makes it more flexible / robust.
Checklist
- [ ] Investigated and inspected CI test results
- [ ] Updated documentation accordingly
Automated testing
- [ ] Added unit tests
- [ ] Added integration tests
- [ ] Added regression tests
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me) Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes") In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Why are P and Z not using identify-image-platforms.outputs.supported_archs
instead of the multiarch
label ?
ah I believe it is because I am a little bit blind 😅
A strange error occurred https://github.com/stackrox/collector/actions/runs/7613242274/job/20732912611?pr=1483#step:15:41
But once this is solved, I suggest to remove the run-multiarch-build
to see whether the tests are skipped.