node-grpc-error-details icon indicating copy to clipboard operation
node-grpc-error-details copied to clipboard

Update grpc library

Open pedroscaff opened this issue 1 year ago • 2 comments

Hello, I hope you are doing well.

I had an issue while running yarn install (extra info: a Dockerfile from node:18-alpine):

Docker build/yarn install logs
#9 [development 3/5] COPY --chown=node:node package*.json ./
#9 sha256:9236c53f8c9ef0499dc6c8fd6f72331a37e04998ce5c07345886fb34b313975d
#9 DONE 0.0s

#8 [build 4/8] COPY --chown=node:node yarn.lock ./
#8 sha256:0ac3af7e6d773474ef50df6c33f0c7b88f3521b01f7049f744c86b672600b67a
#8 DONE 0.0s

#10 [development 4/5] RUN yarn install --frozen-lockfile
#10 sha256:afa8b57c73ac479e07e3d5a3f997af227f649dcbbcd71b312f55b5a44b02f955
#10 5.532 yarn install v1.22.19
#10 5.582 info No lockfile found.
#10 5.589 [1/4] Resolving packages...
#10 9.566 warning @stackpath/node-grpc-error-details > [email protected]: This library will not receive further updates other than security fixes. We recommend using @grpc/grpc-js instead.
#10 10.29 warning @stackpath/node-grpc-error-details > @types/[email protected]: This is a stub types definition for protobufjs (https://github.com/dcodeIO/ProtoBuf.js). protobufjs provides its own type definitions, so you don't need @types/protobufjs installed!
#10 11.97 warning @nestjs/cli > @nestjs/schematics > @angular-devkit/schematics > magic-string > [email protected]: Please use @jridgewell/sourcemap-codec instead
#10 15.43 [2/4] Fetching packages...
#10 30.42 [3/4] Linking dependencies...
#10 30.43 warning " > [email protected]" has unmet peer dependency "webpack@^5.0.0".
#10 40.58 [4/4] Building fresh packages...
#10 42.94 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
#10 42.94 error /usr/src/app/node_modules/grpc: Command failed.
#10 42.94 Exit code: 1
#10 42.94 Command: node-pre-gyp install --fallback-to-build --library=static_library
#10 42.94 Arguments: 
#10 42.94 Directory: /usr/src/app/node_modules/grpc
#10 42.94 Output:
#10 42.94 node-pre-gyp info it worked if it ends with ok
#10 42.94 node-pre-gyp info using [email protected]
#10 42.94 node-pre-gyp info using [email protected] | linux | x64
#10 42.94 node-pre-gyp info check checked for "/usr/src/app/node_modules/grpc/src/node/extension_binary/node-v108-linux-x64-musl/grpc_node.node" (not found)
#10 42.94 node-pre-gyp http GET https://node-precompiled-binaries.grpc.io/grpc/v1.24.11/node-v108-linux-x64-musl.tar.gz
#10 42.94 node-pre-gyp ERR! install response status 404 Not Found on https://node-precompiled-binaries.grpc.io/grpc/v1.24.11/node-v108-linux-x64-musl.tar.gz 

The grpc library is in maintenance mode and since Metadata is the only dependency on the grpc library, I think it is safe to update it and for my case (and probably most of the current use cases) it added no extra dependency since my project already needs the @grpc/grpc-js dependency.

Let me know if I should do something else to get this merged.

  • [x] yarn run test works fine

pedroscaff avatar Mar 29 '23 12:03 pedroscaff