swift-cross-ui icon indicating copy to clipboard operation
swift-cross-ui copied to clipboard

toggleStyle(.checkbox) is broken on Ubuntu 22.04, default backend

Open valeriyvan opened this issue 6 months ago • 6 comments

  • labels are not shown
  • checkmark sign sometimes is not shown

https://github.com/user-attachments/assets/c1de9e24-caad-42a6-9f54-3eda6bf92f57

Here is the same view where toggleStyle(.switch):

https://github.com/user-attachments/assets/99138084-373c-4e24-a967-718ca8d0b3fe

valeriyvan avatar Jun 09 '25 12:06 valeriyvan

I've fixed the label issue on main now (just an oversight on my part), but I can't reproduce the checkmark issue. I've tried on both Ubuntu 22.04 and Ubuntu 24.10. The checkboxes work perfectly on both for me. Is there anything particularly custom about your Ubuntu installation?

stackotter avatar Jun 11 '25 12:06 stackotter

I've fixed the label issue on main now (just an oversight on my part), but I can't reproduce the checkmark issue. I've tried on both Ubuntu 22.04 and Ubuntu 24.10. The checkboxes work perfectly on both for me. Is there anything particularly custom about your Ubuntu installation?

There's nothing custom on my Ubuntu install.

valeriyvan avatar Jun 11 '25 19:06 valeriyvan

I've fixed the label issue on main now (just an oversight on my part), but I can't reproduce the checkmark issue. I've tried on both Ubuntu 22.04 and Ubuntu 24.10. The checkboxes work perfectly on both for me. Is there anything particularly custom about your Ubuntu installation?

It would be significantly easier to track changes if all changes are done with Pull Requests, avoiding direct commits into main,

valeriyvan avatar Jun 12 '25 08:06 valeriyvan

Yeah, I should be doing that, at least for changes bigger than a commit or two. Given that I'm the only maintainer I would just be instant merging my own PRs all the time so it doesn't make as much sense for small commits that take less than 30 minutes imo.

In the context of this issue, what difference do you envision a PR having made? Is searchability the main advantage you want?

stackotter avatar Jun 12 '25 10:06 stackotter

Yeah, I should be doing that, at least for changes bigger than a commit or two. Given that I'm the only maintainer I would just be instant merging my own PRs all the time so it doesn't make as much sense for small commits that take less than 30 minutes imo.

In the context of this issue, what difference do you envision a PR having made? Is searchability the main advantage you want?

yes, searchability. It was already several times when you said you did something and it took me extra effort to find the change. The first place where I start search is PRs tab. Ideally it should be last place also. If there's no PR for that, it didn't happen.

valeriyvan avatar Jun 12 '25 16:06 valeriyvan

Ok thanks for the feedback, I'll take that on board.

Regarding the checkbox issue: does the issue ever occur if you just have a single app with a checkbox? If so, I'll add a checkbox to the Gtk example app to see if this is a Gtk thing or if it's just something Gtk doesn't like about the way SwiftCrossUI's updating things.

stackotter avatar Jun 13 '25 05:06 stackotter