toolhive icon indicating copy to clipboard operation
toolhive copied to clipboard
Published 2 months ago • verified publisher icon stacklok

Drop unused env file field in runconfig

Open dmjb opened this issue 4 months ago • 2 comments

dmjb avatar Oct 15 '25 14:10 dmjb

the command line parameter is used in https://github.com/stacklok/toolhive/blob/73707af47db039f51b2bda07d1ef8eccb25ba819/cmd/thv-operator/controllers/mcpserver_controller.go#L1033

if we are to convert the operator to runconfig shouldn't we retain this option?

jhrozek avatar Oct 15 '25 14:10 jhrozek

Sorry as we discussed the operator ends up setting the environment variables directly and writes to EnvVars

jhrozek avatar Oct 15 '25 14:10 jhrozek