Add additional test coverage for helper functions in Util
Summary
Currently helper functions in Util lacks test coverage
This commit adds test coverage helper functions in Util
Ref #4380
Change Type
Mark the type of change your PR introduces:
- [ ] Bug fix (resolves an issue without affecting existing features)
- [ ] Feature (adds new functionality without breaking changes)
- [ ] Breaking change (may impact existing functionalities or require documentation updates)
- [ ] Documentation (updates or additions to documentation)
- [x] Refactoring or test improvements (no bug fixes or new functionality)
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations. Attach screenshots if helpful.
Review Checklist:
- [x] Reviewed my own code for quality and clarity.
- [x] Added comments to complex or tricky code sections.
- [ ] Updated any affected documentation.
- [ ] Included tests that validate the fix or feature.
- [x] Checked that related changes are merged.
coverage: 53.769% (+0.5%) from 53.264% when pulling 00dd4ba9cfb933088e49aa55ba2f564c18dd3af6 on gajananan:improve-test-coverage-util-helpers into 49f192a44c7dd19ddadb0e03cbeba4c45dde0bda on stacklok:main.
@gajananan
It looks like this is close to the finish line -- any chance you can incorporate the feedback (and fix conflicts) in the next week?
Hi @gajananan,
We'd love to get this merged! If you don't have time to work on this, we'll probably have someone over here at Stacklok apply the requested changes and merge it.
Hey @gajananan -- we'd love to get this PR in. I ran into one of your co-workers at KubeCon, and they said that your work schedule might be preventing you from updating. A quick note of "I can get to this within a week" or "please carry this forward, I'm busy now" would be handy.
Thanks again for your work so far!
This PR needs additional information before we can continue. It is now marked as stale because it has been open for 30 days with no activity. Please provide the necessary details to continue or it will be closed in 30 days.
Hey @gajananan -- we'd love to get this PR in. I ran into one of your co-workers at KubeCon, and they said that your work schedule might be preventing you from updating. A quick note of "I can get to this within a week" or "please carry this forward, I'm busy now" would be handy.
Thanks again for your work so far!
My sincere apologies for long silence on this. I would take it forward with addressing the comments/feedback
A few more small nits, but this is looking very close! In particular, I think you want
SetEnvVarto take care of restoring the environment variable; the other fixes are purely your choice / passing along some experience maintaining Go code.
Thank you for your detailed feedback which helped a lot to learn the code base. I addressed the remainder of the comments as well.