minder icon indicating copy to clipboard operation
minder copied to clipboard

Add additional test coverage for helper functions in Util

Open gajananan opened this issue 1 year ago • 1 comments

Summary

Currently helper functions in Util lacks test coverage

This commit adds test coverage helper functions in Util

Ref #4380

Change Type

Mark the type of change your PR introduces:

  • [ ] Bug fix (resolves an issue without affecting existing features)
  • [ ] Feature (adds new functionality without breaking changes)
  • [ ] Breaking change (may impact existing functionalities or require documentation updates)
  • [ ] Documentation (updates or additions to documentation)
  • [x] Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations. Attach screenshots if helpful.

Review Checklist:

  • [x] Reviewed my own code for quality and clarity.
  • [x] Added comments to complex or tricky code sections.
  • [ ] Updated any affected documentation.
  • [ ] Included tests that validate the fix or feature.
  • [x] Checked that related changes are merged.

gajananan avatar Oct 05 '24 10:10 gajananan

Coverage Status

coverage: 53.769% (+0.5%) from 53.264% when pulling 00dd4ba9cfb933088e49aa55ba2f564c18dd3af6 on gajananan:improve-test-coverage-util-helpers into 49f192a44c7dd19ddadb0e03cbeba4c45dde0bda on stacklok:main.

coveralls avatar Oct 05 '24 10:10 coveralls

@gajananan

It looks like this is close to the finish line -- any chance you can incorporate the feedback (and fix conflicts) in the next week?

evankanderson avatar Oct 23 '24 13:10 evankanderson

Hi @gajananan,

We'd love to get this merged! If you don't have time to work on this, we'll probably have someone over here at Stacklok apply the requested changes and merge it.

evankanderson avatar Nov 06 '24 14:11 evankanderson

Hey @gajananan -- we'd love to get this PR in. I ran into one of your co-workers at KubeCon, and they said that your work schedule might be preventing you from updating. A quick note of "I can get to this within a week" or "please carry this forward, I'm busy now" would be handy.

Thanks again for your work so far!

evankanderson avatar Nov 19 '24 14:11 evankanderson

This PR needs additional information before we can continue. It is now marked as stale because it has been open for 30 days with no activity. Please provide the necessary details to continue or it will be closed in 30 days.

github-actions[bot] avatar Dec 20 '24 02:12 github-actions[bot]

Hey @gajananan -- we'd love to get this PR in. I ran into one of your co-workers at KubeCon, and they said that your work schedule might be preventing you from updating. A quick note of "I can get to this within a week" or "please carry this forward, I'm busy now" would be handy.

Thanks again for your work so far!

My sincere apologies for long silence on this. I would take it forward with addressing the comments/feedback

gajananan avatar Jan 18 '25 04:01 gajananan

A few more small nits, but this is looking very close! In particular, I think you want SetEnvVar to take care of restoring the environment variable; the other fixes are purely your choice / passing along some experience maintaining Go code.

Thank you for your detailed feedback which helped a lot to learn the code base. I addressed the remainder of the comments as well.

gajananan avatar Jan 27 '25 01:01 gajananan

Coverage Status

coverage: 57.432% (+0.8%) from 56.641% when pulling 50087af354aabcf4014ef8208e949e224443540d on gajananan:improve-test-coverage-util-helpers into fcb8ab6cb0ef7ec0cccc0b9869428f350287cc37 on mindersec:main.

coveralls avatar Jan 29 '25 18:01 coveralls