minder icon indicating copy to clipboard operation
minder copied to clipboard

Improve existing logs

Open blkt opened this issue 1 year ago • 0 comments

Remove unnecessary logs from Minder codebase, the rule of thumb is

  • most debug messages are unnecessary or useful
  • if a debug message is truly necessary or useful, bump it to info
  • some error messages are not errors, either remove them or lower them to debug

Bearing in mind that the current list is based on code paths hit by smoke tests and might thus be biased, spots in the code worth looking for first are

  • https://github.com/stacklok/minder/tree/main/internal/engine/rtengine
  • https://github.com/stacklok/minder/blob/main/internal/engine/eval/trusty/trusty.go#L246
  • https://github.com/stacklok/minder/blob/main/internal/engine/actions/remediate/pull_request/pull_request.go#L287
  • https://github.com/stacklok/minder/blob/main/internal/engine/actions/alert/security_advisory/security_advisory.go#L218
  • https://github.com/stacklok/minder/blob/main/internal/controlplane/handlers_profile.go#L448
  • https://github.com/stacklok/minder/blob/main/internal/entities/properties/service/helpers.go#L37
  • https://github.com/stacklok/minder/blob/6514ae4d446e0550629a77c2c60f1dfb7d16cb90/internal/authz/authz.go#L385-L388

blkt avatar Oct 02 '24 12:10 blkt