minder icon indicating copy to clipboard operation
minder copied to clipboard

Ensure a transaction is open in `ReplaceAllProperties` routine

Open blkt opened this issue 1 year ago • 3 comments

This routine must ensure that a transaction is open before performing the delete/insert sequence of statements.

blkt avatar Sep 10 '24 08:09 blkt

I looked into this issue and I believe it has already been fixed? I am seeing that there is a call to get a transaction on line 180.

I am new to the repo so if I am wrong I apologize!

tjb avatar Jan 18 '25 23:01 tjb

getStoreOrTransaction doesn't ensure that there is a transaction in progress; if there is no transaction in progress, it will return a db.Store, which will be in Postgres' auto-transaction-for-each-statement mode.

evankanderson avatar Jan 20 '25 05:01 evankanderson

(This is based on reading #4459)

evankanderson avatar Jan 20 '25 05:01 evankanderson